Add deprecation rules for cycleway=opposite_lane #Part2
#1297
Conversation
We found cases where oneway=yes is not the right update path because access tags are used instead. We assume, that oneway=yes is usually tagged already, so we don't need to add it to the replacement. However, the oneway:bicycle=no is used less often and also does less harm in case someone does apply the deprecation in cases where it should not be applied.
Those rules apply best for right hand traffic.
|
🍱 You can preview the tagging presets of this pull request here. |
| }, | ||
| { | ||
| "old": {"cycleway": "opposite_lane"}, | ||
| "replace": {"oneway:bicycle": "no", "cycleway:left": "lane", "cycleway:left:oneway": "-1"} |
There was a problem hiding this comment.
I think this rule is wrong in countries that drive on the left (which affects 67 ways)
It's also wrong if the road has oneway=-1 (which affects 2 ways)
So I think these 69 examples need to be manually fixed before we can introduce the rule
...or we could make a fairly simple change to iD, so that deprecation rules can be limited to certain countries or driving sides. (we already have this data from https://github.com/rapideditor/country-coder)
There was a problem hiding this comment.
Thanks for confirming the issue on left-hand traffic!
I will wait for #1295 to be merged before thinking more about this, though. Just not to invest too much time – given our longer backlog. :)
This is based on top of #1295 and #1295 should be merged first.
I split off the
opposite_lanebecause they are a bit more complex.We are talking about 5.136 + 7.158 cases that this rule would apply to.
The replacement is following the examples from the proposal https://wiki.openstreetmap.org/wiki/Proposal:Deprecate_cycleway%3Dopposite_family#Tagging_and_Examples an I checked them with @SupaplexOSM.
One thing that makes this more complex is, that countries with Left-hand traffic, those deprecations might not be right.
However, it looks like those are only 18 cases for UK https://taginfo.geofabrik.de/europe:britain-and-ireland/search?q=cycleway%3Aleft%3Dopposite#tags because the more common tag would be https://taginfo.geofabrik.de/europe:britain-and-ireland/search?q=cycleway%3Aright%3Dopposite#tags there (also only ~200 cases).
I think it would be fine to merge this.
However I also think, it would be fine to leave it and handle those cases with a MapRoulette Project instead.