-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add high level documentation for disconnected envs #1253
Add high level documentation for disconnected envs #1253
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
433e914
to
c3a3700
Compare
c3a3700
to
c88aada
Compare
|
||
[,yaml] | ||
---- | ||
edpm_podman_disconnected_ocp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would not mentioning these ansible variables that are for internal use confuse the users? Though the section heading is Technical Overview
i.e how it internally works, we should probably clearly mention that user does not have to do anything from OSP pov once OCP operataor catalog mirroring is done, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, true, don't wan to cause any confusion. I can make that more clear.
c88aada
to
f9463df
Compare
|
||
The `openstack-operator` contains a list of related images that will ensure all required images for the deployment are mirrored following the above OpenShift process. Once images are mirrored, the `ImageContentSourcePolicy` custom resource (CR) is created. This process results in a `MachineConfig` called `99-master-genereted-registries` being updated in the cluster. The `99-master-generated-registries` `MachineConfig` contains a `registries.conf` file that is applied to all of the OpenShift nodes in the cluster. | ||
|
||
In order to integrate cleanly with this process. The dataplane controller will check for the existence of an `ImageContentSourcePolicy`. If one is found, we will read the `registries.conf` file from the `99-master-generated-registries` `MachineConfig`. The dataplane controller will then set two variables in the Ansible inventory for the nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/dataplane controller/openstack-operator ?
The first sentence is also a fragment:
In order to integrate cleanly with this process.
I would rewrite this as:
In order for EDPM to integrate cleanly with this process, openstack-operator checks for the existence of an `ImageContentSourcePolicy`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed all of the "we"'s as well. I just swapped EDPM for dataplane since I hadn't already referenced the acronym anywhere else, I just stuck with dataplane.
docs/assemblies/proc_deploying-in-disconnected-environments.adoc
Outdated
Show resolved
Hide resolved
1e75371
to
5ae2550
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Signed-off-by: Brendan Shephard <[email protected]>
5ae2550
to
3be17a3
Compare
New changes are detected. LGTM label has been removed. |
/retest |
2afb680
into
openstack-k8s-operators:main
No description provided.