Fix visualization of pathpoints defined wrt offset frames (#1518)

* Fix visualization of pathpoints defined wrt offset frames

* Update CHANGELOG.md

[skip ci]

CHANGELOG.md

@@ -8,6 +8,7 @@ v4.6
 ======
 - Fix issue [#1494](https://github.com/opensim-org/opensim-gui/issues/1494): Changing muscle path color throws exception.
 - Fix issue [#1493](https://github.com/opensim-org/opensim-gui/issues/1493): Rotating experimental data fails or results an unusable file.
+- Fix issue [#1516](https://github.com/opensim-org/opensim-gui/issues/1516): Chains of Physical offset frames ignored when displaying GeometryPath 
 
 v4.5
 ======

Gui/opensim/view/src/org/opensim/threejs/ModelVisualizationJson.java

@@ -1602,7 +1602,15 @@ public JSONObject createPathPointObjectJson(AbstractPathPoint pathPoint, boolean
         Transform localTransform = new Transform();
         if (active && pathPoint!= null){
             Vec3 location = pathPoint.getLocation(state);
-            localTransform.setP(location);
+            Frame parentFrame = pathPoint.getParentFrame();
+            Frame baseFrame = parentFrame.findBaseFrame();
+            if (baseFrame.equals(parentFrame))
+                localTransform.setP(location);
+            else {
+                // transform location to baseFrame as the scene graph for visualization uses it for mobodyindex
+                Vec3 locationInBaseFrame = parentFrame.findStationLocationInAnotherFrame(state, location, baseFrame);
+                localTransform.setP(locationInBaseFrame);
+            }
         }
         else
             localTransform.setP(computedLocation);