Add unique github id check #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
============================================
+ Coverage 86.84% 86.87% +0.02%
- Complexity 317 318 +1
============================================
Files 69 69
Lines 1764 1767 +3
Branches 79 80 +1
============================================
+ Hits 1532 1535 +3
Misses 195 195
Partials 37 37 ☔ View full report in Codecov by Sentry. |
| maintainersList.add(maintainerData); | ||
| if(!maintainerIdSet.contains(githubId)){ // Add only unique github ids | ||
| maintainerIdSet.add(githubId); | ||
| maintainersList.add(maintainerData); |
There was a problem hiding this comment.
After added to maintainerIdSet, where is this maintainerIdSet used? Still I see as maintainersList.add(maintainerData);.
There was a problem hiding this comment.
Line 257 to check if the id is within the set
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import java.util.*; |
There was a problem hiding this comment.
Better not to use the .*;.
Thanks
bshien
force-pushed
the
maintainer-engagement-4
branch
from
0eb6218
to
f8967e2
Compare
Signed-off-by: Brandon Shien <[email protected]>
bshien
force-pushed
the
maintainer-engagement-4
branch
from
f8967e2
to
dee9e74
Compare
prudhvigodithi
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unique github id check when scraping MAINTAINERS.md file in case of duplicate github ids.
Issues Resolved
Part of #75
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.