Add unique github id check

Signed-off-by: Brandon Shien <[email protected]>
opensearch-project · Nov 4, 2024 · f8967e2 · f8967e2
1 parent 91099eb
commit f8967e2
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/src/main/java/org/opensearchmetrics/metrics/maintainer/MaintainerMetrics.java b/src/main/java/org/opensearchmetrics/metrics/maintainer/MaintainerMetrics.java
@@ -237,6 +237,7 @@ public List<MaintainerData> repoMaintainers(String repo) {
         String rawMaintainersFile = String.format("https://raw.githubusercontent.com/opensearch-project/%s/main/MAINTAINERS.md", repo);
         boolean isEmeritusSection = false;
         List<MaintainerData> maintainersList = new ArrayList<>();
+        Set<String> maintainerIdSet = new HashSet<>();
         try (BufferedReader reader = new BufferedReader(new InputStreamReader(new URL(rawMaintainersFile).openStream(),
                 StandardCharsets.UTF_8))) {
             String line;
@@ -256,7 +257,10 @@ public List<MaintainerData> repoMaintainers(String repo) {
                             maintainerData.setName(maintainer);
                             maintainerData.setGithubLogin(githubId);
                             maintainerData.setAffiliation(affiliation);
-                            maintainersList.add(maintainerData);
+                            if(!maintainerIdSet.contains(githubId)){ // Add only unique github ids
+                                maintainerIdSet.add(githubId);
+                                maintainersList.add(maintainerData);
+                            }
                         }
                     }
                 } else if (line.contains("Emeritus")) {

diff --git a/src/test/java/org/opensearchmetrics/metrics/maintainer/MaintainerMetricsTest.java b/src/test/java/org/opensearchmetrics/metrics/maintainer/MaintainerMetricsTest.java
@@ -311,6 +311,37 @@ public void testRepoMaintainers() {
         }
     }
 
+    @Test
+    public void testRepoMaintainersDuplicateId() {
+        MaintainerMetrics maintainerMetrics = new MaintainerMetrics();
+        String expectedContent = "test content\n" +
+                "| Maintainer       | GitHub ID                                | Affiliation |\n" +
+                "| maintainer | [githubId](https://github.com/githubId) | affiliation      |\n" +
+                "| maintainer | [githubId](https://github.com/githubId) | affiliation      |\n" +
+                "## Emeritus Maintainers" +
+                "| maintainer | [githubId](https://github.com/githubId) | affiliation      |\n" +
+                "line3\n";
+        ByteArrayInputStream inputStream = new ByteArrayInputStream(
+                expectedContent.getBytes(StandardCharsets.UTF_8)
+        );
+
+        try (MockedConstruction<URL> mocked = mockConstruction(URL.class, (mockUrl, context) ->
+                when(mockUrl.openStream()).thenReturn(inputStream))) {
+
+            List<MaintainerData> maintainerDataList = maintainerMetrics.repoMaintainers("repo");
+
+            List<MaintainerData> expectedList = new ArrayList<>();
+            MaintainerData expectedMaintainer = new MaintainerData();
+            expectedMaintainer.setRepository("repo");
+            expectedMaintainer.setName("maintainer");
+            expectedMaintainer.setGithubLogin("githubId");
+            expectedMaintainer.setAffiliation("affiliation");
+            expectedList.add(expectedMaintainer);
+
+            assertEquals(expectedList, maintainerDataList);
+        }
+    }
+
     @Test
     public void testRepoMaintainersFileNotFound() {
         MaintainerMetrics maintainerMetrics = new MaintainerMetrics();