Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating the approval requirement #3148

Merged
merged 1 commit into from
Oct 23, 2024
Merged

updating the approval requirement #3148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/require-approval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
# Handle Pull Request events

# Check if the PR is triggered by opensearch-trigger-bot
if [[ "$github_event" == "pull_request" ]] && [[ "$author" == "opensearch-trigger-bot[bot]" ]]; then
if [[ "$author" == "opensearch-trigger-bot[bot]" ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, this author opensearch-trigger-bot[bot] should be some Github unique user ID , right ? Is it possible someone else bypass with same name?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the opensearch-trigger-bot[bot] is a unique bot account managed by GitHub, and its identity is authenticated by GitHub's infrastructure. Regular users cannot impersonate it or spoof its actions by just creating an account with a similar name.

echo "PR triggered by opensearch-trigger-bot. No approval needed."
echo "is-require-approval=ml-commons-cicd-env" >> $GITHUB_OUTPUT
else
Expand Down
Loading