updating the approval requirement #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhrubo Saha <[email protected]>
dhrubo-os
requested review from
b4sjoo,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
samuel-oci and
xinyual
as code owners
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
reviewed
Oct 23, 2024
| @@ -29,7 +29,7 @@ jobs: | |||
| # Handle Pull Request events | |||
|
|
|||
| # Check if the PR is triggered by opensearch-trigger-bot | |||
| if [[ "$github_event" == "pull_request" ]] && [[ "$author" == "opensearch-trigger-bot[bot]" ]]; then | |||
| if [[ "$author" == "opensearch-trigger-bot[bot]" ]]; then | |||
There was a problem hiding this comment.
Just curious, this author opensearch-trigger-bot[bot] should be some Github unique user ID , right ? Is it possible someone else bypass with same name?
There was a problem hiding this comment.
the opensearch-trigger-bot[bot] is a unique bot account managed by GitHub, and its identity is authenticated by GitHub's infrastructure. Regular users cannot impersonate it or spoof its actions by just creating an account with a similar name.
dhrubo-os
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Oct 23, 2024
mingshl
approved these changes
Oct 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit c195fd6)
dhrubo-os
added a commit
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit c195fd6) Co-authored-by: Dhrubo Saha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[updating the approval requirement so that it can trigger always for opensearch-trigger-bot[bot]]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.