Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test Env Require Approval Action #3005

Merged
merged 5 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/CI-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,16 @@ permissions:
contents: read

jobs:
Get-Require-Approval:
uses: ./.github/workflows/require-approval.yml

Get-CI-Image-Tag:
uses: opensearch-project/opensearch-build/.github/workflows/get-ci-image-tag.yml@main
with:
product: opensearch

Build-ml-linux:
needs: Get-CI-Image-Tag
needs: [Get-Require-Approval, Get-CI-Image-Tag]
strategy:
matrix:
java: [21]
Expand All @@ -29,7 +32,7 @@ jobs:

name: Build and Test MLCommons Plugin on linux
if: github.repository == 'opensearch-project/ml-commons'
environment: ml-commons-cicd-env
environment: ${{ needs.Get-Require-Approval.outputs.is-require-approval }}
outputs:
build-test-linux: ${{ steps.step-build-test-linux.outputs.build-test-linux }}
runs-on: ubuntu-latest
Expand Down Expand Up @@ -87,14 +90,14 @@ jobs:


Test-ml-linux-docker:
needs: Build-ml-linux
needs: [Get-Require-Approval, Build-ml-linux]
strategy:
matrix:
java: [21]

name: Test MLCommons Plugin on linux docker
if: github.repository == 'opensearch-project/ml-commons'
environment: ml-commons-cicd-env
environment: ${{ needs.Get-Require-Approval.outputs.is-require-approval }}
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -189,7 +192,8 @@ jobs:
java: [21]
name: Build and Test MLCommons Plugin on Windows
if: github.repository == 'opensearch-project/ml-commons'
environment: ml-commons-cicd-env
needs: [Get-Require-Approval]
environment: ${{ needs.Get-Require-Approval.outputs.is-require-approval }}
runs-on: windows-latest

steps:
Expand Down
36 changes: 36 additions & 0 deletions .github/workflows/require-approval.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
name: Check if the workflow require approval
on:
workflow_call:
outputs:
is-require-approval:
description: The ci image version for linux build
value: ${{ jobs.Require-Approval.outputs.output-is-require-approval }}

jobs:
Require-Approval:
runs-on: ubuntu-latest
outputs:
output-is-require-approval: ${{ steps.step-is-require-approval.outputs.is-require-approval }}
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.base.sha }}
- name: Get CodeOwner List
id: step-is-require-approval
run: |
github_event=${{ github.event_name }}
if [[ "$github_event" = "push" ]]; then
echo "Push event does not need approval"
echo "is-require-approval=ml-commons-cicd-env" >> $GITHUB_OUTPUT
else
approvers=$(cat .github/CODEOWNERS | grep @ | tr -d '* ' | sed 's/@/,/g' | sed 's/,//1')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So currently, it's maintainers vs non-maintainers, right?

not maintainers + organization vs non-maintainers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is easier to get maintainers list, we will start from here and improve.

author=${{ github.event.pull_request.user.login }}
if [[ "$approvers" =~ "$author" ]]; then
echo "$authoer is in the approval list"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] author

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

echo "is-require-approval=ml-commons-cicd-env" >> $GITHUB_OUTPUT
else
echo "$author is not in the approval list"
echo "is-require-approval=ml-commons-cicd-env-require-approval" >> $GITHUB_OUTPUT
fi
fi
Loading