Add Test Env Require Approval Action #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout approval Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
samuel-oci and
xinyual
as code owners
peterzhuamazon
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
Adding @ylwu-amzn @dhrubo-os to take a look. Note you need to merge this PR before it take effect as it is Pull_Request_Target event. Thanks. |
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
peterzhuamazon
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
reviewed
Sep 30, 2024
| echo "Push event does not need approval" | ||
| echo "is-require-approval=ml-commons-cicd-env" >> $GITHUB_OUTPUT | ||
| else | ||
| approvers=$(cat .github/CODEOWNERS | grep @ | tr -d '* ' | sed 's/@/,/g' | sed 's/,//1') |
There was a problem hiding this comment.
So currently, it's maintainers vs non-maintainers, right?
not maintainers + organization vs non-maintainers?
There was a problem hiding this comment.
Yes, it is easier to get maintainers list, we will start from here and improve.
dhrubo-os
reviewed
Sep 30, 2024
| approvers=$(cat .github/CODEOWNERS | grep @ | tr -d '* ' | sed 's/@/,/g' | sed 's/,//1') | ||
| author=${{ github.event.pull_request.user.login }} | ||
| if [[ "$approvers" =~ "$author" ]]; then | ||
| echo "$authoer is in the approval list" |
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
approved these changes
Sep 30, 2024
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
peterzhuamazon
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Sep 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
* Add require approval stage so only maintainers can start CI stage without approval Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> * Add old files Signed-off-by: Peter Zhu <[email protected]> * Update require-approval.yml Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 9de2d23)
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 1, 2024
* Add require approval stage so only maintainers can start CI stage without approval Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> * Add old files Signed-off-by: Peter Zhu <[email protected]> * Update require-approval.yml Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 9de2d23) Co-authored-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Test Env Require Approval Action.
Every time when a PR get created:
.github/CODEOWNERS, assignml-commons-cicd-env-required-approval, pending for review by the assigned maintainers of the env.ml-commons-cicd-env, no need approval.ml-commons-cicd-envassigned, no need approval.Example waiting for approval by maintainer: #3004.
Thanks.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.