Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skills PPLTool execution cluster setting #7857

Closed
wants to merge 2 commits into from
Closed

Add skills PPLTool execution cluster setting #7857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a631df5
Add skills PPLTool execution cluster setting
zane-neo Jul 30, 2024
9b93cef
Add description for skills ppl execution setting
zane-neo Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions _ml-commons-plugin/cluster-settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,3 +492,17 @@

- Default value: `true`
- Valid values: `false`, `true`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a heading level 2 before this section that says what the setting does and a description of the setting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, add description.

## Enable PPL execution in PPLTool

Check failure on line 496 in _ml-commons-plugin/cluster-settings.md

View workflow job for this annotation

GitHub Actions / style-job 

[vale] reported by reviewdog 🐶
[OpenSearch.Spelling] Error: PPLTool. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.

Raw Output:
{"message": "[OpenSearch.Spelling] Error: PPLTool. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.", "location": {"path": "_ml-commons-plugin/cluster-settings.md", "range": {"start": {"line": 496, "column": 28}}}, "severity": "ERROR"}
PPLTool is one of the tools in agent framework, this tool can generate PPL based on natrual language and execute the generated PPL. This setting provides cluster level control on whether execute PPL. When set to false, PPL will not execute, when set to true, PPLTool honers the `execute` parameter in PPLTool itself.

Check failure on line 497 in _ml-commons-plugin/cluster-settings.md

View workflow job for this annotation

GitHub Actions / style-job 

[vale] reported by reviewdog 🐶
[OpenSearch.Spelling] Error: PPLTool. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.

Raw Output:
{"message": "[OpenSearch.Spelling] Error: PPLTool. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.", "location": {"path": "_ml-commons-plugin/cluster-settings.md", "range": {"start": {"line": 497, "column": 1}}}, "severity": "ERROR"}

Check failure on line 497 in _ml-commons-plugin/cluster-settings.md

View workflow job for this annotation

GitHub Actions / style-job 

[vale] reported by reviewdog 🐶
[OpenSearch.Spelling] Error: natrual. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.

Raw Output:
{"message": "[OpenSearch.Spelling] Error: natrual. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.", "location": {"path": "_ml-commons-plugin/cluster-settings.md", "range": {"start": {"line": 497, "column": 85}}}, "severity": "ERROR"}

Check failure on line 497 in _ml-commons-plugin/cluster-settings.md

View workflow job for this annotation

GitHub Actions / style-job 

[vale] reported by reviewdog 🐶
[OpenSearch.Spelling] Error: PPLTool. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.

Raw Output:
{"message": "[OpenSearch.Spelling] Error: PPLTool. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.", "location": {"path": "_ml-commons-plugin/cluster-settings.md", "range": {"start": {"line": 497, "column": 260}}}, "severity": "ERROR"}

Check failure on line 497 in _ml-commons-plugin/cluster-settings.md

View workflow job for this annotation

GitHub Actions / style-job 

[vale] reported by reviewdog 🐶
[OpenSearch.Spelling] Error: PPLTool. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.

Raw Output:
{"message": "[OpenSearch.Spelling] Error: PPLTool. If you are referencing a setting, variable, format, function, or repository, surround it with tic marks.", "location": {"path": "_ml-commons-plugin/cluster-settings.md", "range": {"start": {"line": 497, "column": 302}}}, "severity": "ERROR"}

### Setting

```
plugins.skills.ppl_execution_enabled: false
```

### Values

- Default value: `false`
- Valid values: `false`, `true`
Loading