Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skills PPLTool execution cluster setting #7857

Closed

Conversation

zane-neo
Copy link
Contributor

Description

Add skills PPLTool execution cluster setting

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Version

List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@hdhalter
Copy link
Contributor

@zane-neo - Is this new for 2.16 or something that was missed before?

@zane-neo
Copy link
Contributor Author

zane-neo commented Aug 1, 2024

@zane-neo - Is this new for 2.16 or something that was missed before?

This is for 2.16.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a name/description for this setting before line 495.

@@ -492,3 +492,14 @@ plugins.ml_commons.rag_pipeline_feature_enabled: true

- Default value: `true`
- Valid values: `false`, `true`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a heading level 2 before this section that says what the setting does and a description of the setting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, add description.

@kolchfa-aws kolchfa-aws added release-notes PR: Include this PR in the automated release notes v2.16.0 labels Aug 1, 2024
@hdhalter hdhalter added the 4 - Doc review PR: Doc review in progress label Aug 1, 2024
@zane-neo
Copy link
Contributor Author

zane-neo commented Aug 3, 2024

Please hold on the merge, confirming if this PR is necessary.

@zane-neo
Copy link
Contributor Author

zane-neo commented Aug 3, 2024

This is not necessary since the cluster setting code has been reverted: opensearch-project/skills#381, closing it now.

@zane-neo zane-neo closed this Aug 3, 2024
@hdhalter hdhalter added Closed - Duplicate or Cancelled Issue: Nothing to be done and removed 4 - Doc review PR: Doc review in progress release-notes PR: Include this PR in the automated release notes v2.16.0 labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed - Duplicate or Cancelled Issue: Nothing to be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants