-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skills PPLTool execution cluster setting #7857
Add skills PPLTool execution cluster setting #7857
Conversation
Signed-off-by: zane-neo <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
@zane-neo - Is this new for 2.16 or something that was missed before? |
This is for 2.16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a name/description for this setting before line 495.
@@ -492,3 +492,14 @@ plugins.ml_commons.rag_pipeline_feature_enabled: true | |||
|
|||
- Default value: `true` | |||
- Valid values: `false`, `true` | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a heading level 2 before this section that says what the setting does and a description of the setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, add description.
Signed-off-by: zane-neo <[email protected]>
Please hold on the merge, confirming if this PR is necessary. |
This is not necessary since the cluster setting code has been reverted: opensearch-project/skills#381, closing it now. |
Description
Add skills PPLTool execution cluster setting
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Version
List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.