-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move get monitor and search monitor action / request / responses to common-utils #566
Merged
bowenlan-amzn
merged 4 commits into
opensearch-project:main
from
ohltyler:alerting-migration
Nov 22, 2023
Merged
Move get monitor and search monitor action / request / responses to common-utils #566
bowenlan-amzn
merged 4 commits into
opensearch-project:main
from
ohltyler:alerting-migration
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
lezzago,
qreshi,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep,
sbcd90 and
AWSHurneyt
as code owners
November 21, 2023 17:11
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
============================================
- Coverage 75.14% 74.05% -1.10%
- Complexity 874 877 +3
============================================
Files 130 133 +3
Lines 5685 5789 +104
Branches 698 708 +10
============================================
+ Hits 4272 4287 +15
- Misses 1104 1191 +87
- Partials 309 311 +2 ☔ View full report in Codecov by Sentry. |
1 task
Related PR in alerting: opensearch-project/alerting#1305 |
eirsep
previously approved these changes
Nov 21, 2023
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
changed the title
Move get monitor action / request / response to common-utils
Move get monitor and search monitor action / request / responses to common-utils
Nov 21, 2023
eirsep
approved these changes
Nov 22, 2023
bowenlan-amzn
approved these changes
Nov 22, 2023
bowenlan-amzn
merged commit Nov 22, 2023
2ff995b
into
opensearch-project:main
10 of 11 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
…ommon-utils (#566) * Add get monitor request/response Signed-off-by: Tyler Ohlsen <[email protected]> * Remove status from response; add to interface Signed-off-by: Tyler Ohlsen <[email protected]> * Add UT Signed-off-by: Tyler Ohlsen <[email protected]> * Repeat for search monitor action Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2ff995b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
lezzago
pushed a commit
that referenced
this pull request
Nov 22, 2023
…ommon-utils (#566) (#567) * Add get monitor request/response * Remove status from response; add to interface * Add UT * Repeat for search monitor action --------- (cherry picked from commit 2ff995b) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
5 tasks
5 tasks
engechas
pushed a commit
to engechas/common-utils
that referenced
this pull request
Feb 12, 2024
…ommon-utils (opensearch-project#566) * Add get monitor request/response Signed-off-by: Tyler Ohlsen <[email protected]> * Remove status from response; add to interface Signed-off-by: Tyler Ohlsen <[email protected]> * Add UT Signed-off-by: Tyler Ohlsen <[email protected]> * Repeat for search monitor action Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
…ommon-utils (opensearch-project#566) (opensearch-project#567) * Add get monitor request/response * Remove status from response; add to interface * Add UT * Repeat for search monitor action --------- (cherry picked from commit 2ff995b) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves get monitor and search monitor action, request, and response definitions (and all tests) from alerting to this plugin. This is so we can expose get monitor & search monitor functionality at the transport level using
AlertingPluginInterface
. This follows the same strategy as previous migrations - see #254 as an example.getMonitor
andsearchMonitors
fn inAlertingPluginInterface
GET_MONITOR_ACTION_NAME
/GET_MONITOR_ACTION_TYPE
,SEARCH_MONITORS_ACTION_NAME
/SEARCH_MONITORS_ACTION_TYPE
inAlertingActions
GetMonitorRequest
/GetMonitorResponse
/GetMonitorRequest
and related testsstatus
field fromGetMonitorResponse
. This is so we can change the response from extendingActionResponse
andToXContentObject
explicitly, and changing toBaseResponse
, which has an override forgetStatus()
. Note theBaseResponse
extends the sameActionResponse
andToXContentObject
. This follows the same approach as done previously - see https://github.com/opensearch-project/alerting/pull/556/files as an example.Confirmed the existing tests and added test in
AlertingPluginInterfaceTests
are passing. I've also confirmed this doesn't break functionality when alerting takes a dependency on these changes - there will be a follow up PR in alerting to change the dependencies from the alerting plugin definitions -> common-utils definitions.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.