[Backport 2.x] Move get monitor and search monitor action / request / responses to common-utils #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…ommon-utils (#566) * Add get monitor request/response Signed-off-by: Tyler Ohlsen <[email protected]> * Remove status from response; add to interface Signed-off-by: Tyler Ohlsen <[email protected]> * Add UT Signed-off-by: Tyler Ohlsen <[email protected]> * Repeat for search monitor action Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2ff995b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn
approved these changes
Nov 22, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #567 +/- ##
============================================
- Coverage 74.05% 72.99% -1.06%
- Complexity 853 856 +3
============================================
Files 130 133 +3
Lines 5669 5773 +104
Branches 697 707 +10
============================================
+ Hits 4198 4214 +16
- Misses 1161 1248 +87
- Partials 310 311 +1 ☔ View full report in Codecov by Sentry. |
eirsep
approved these changes
Nov 22, 2023
lezzago
approved these changes
Nov 22, 2023
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
…ommon-utils (opensearch-project#566) (opensearch-project#567) * Add get monitor request/response * Remove status from response; add to interface * Add UT * Repeat for search monitor action --------- (cherry picked from commit 2ff995b) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2ff995b from #566.