-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting Enhancements: Alerting Comments (Experimental) #1561
Alerting Enhancements: Alerting Comments (Experimental) #1561
Conversation
Signed-off-by: Dennis Toepker <[email protected]>
…nd AlertContext field, but only AlertContext field Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
alerting/src/main/kotlin/org/opensearch/alerting/BucketLevelMonitorRunner.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/AlertService.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
alerting/src/main/kotlin/org/opensearch/alerting/AlertService.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
alerting/src/main/kotlin/org/opensearch/alerting/BucketLevelMonitorRunner.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestSearchAlertingCommentAction.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestSearchMonitorAction.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/resources/org/opensearch/alerting/comments/alerting_comments.json
Show resolved
Hide resolved
let's add some more tests to verify all the behavior and edge cases. |
rest lgtm , approving assuming CI will pass. But make sure CI passes before merging |
Signed-off-by: Dennis Toepker <[email protected]>
We will fix the CIs in follow up PR. @toepkerd is working on it |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1561-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d808474cf308943b0424bebe2192c2d8bcfc4b18
# Push it to GitHub
git push --set-upstream origin backport-1561-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.x Then, create a pull request where the |
#1561) (#1572) * Alerting Enhancements: Alerting Comments (Experimental) (#1561) * initial commit, functional but needs refactoring Signed-off-by: Dennis Toepker <[email protected]> * refactored QueryLevelTriggerExecutionContext to not need both Alert and AlertContext field, but only AlertContext field Signed-off-by: Dennis Toepker <[email protected]> * misc additions and fixes Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup Signed-off-by: Dennis Toepker <[email protected]> * misc changes and basic ITs Signed-off-by: Dennis Toepker <[email protected]> * cleanup Signed-off-by: Dennis Toepker <[email protected]> * renaming notes to comments Signed-off-by: Dennis Toepker <[email protected]> * misc changes Signed-off-by: Dennis Toepker <[email protected]> * changed API endpoints Signed-off-by: Dennis Toepker <[email protected]> * more misc changes and fixes Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup Signed-off-by: Dennis Toepker <[email protected]> * updated a comment Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup and setting refresh policy to immediate Signed-off-by: Dennis Toepker <[email protected]> * fixed lint issues and other restructuring Signed-off-by: Dennis Toepker <[email protected]> * review-based changes Signed-off-by: Dennis Toepker <[email protected]> * update after adding entityType to Comment model Signed-off-by: Dennis Toepker <[email protected]> * misc fixes Signed-off-by: Dennis Toepker <[email protected]> * removing comments history enabled setting Signed-off-by: Dennis Toepker <[email protected]> * adding release notes Signed-off-by: Dennis Toepker <[email protected]> * IT fixes Signed-off-by: Dennis Toepker <[email protected]> * removing dev code vestiges Signed-off-by: Dennis Toepker <[email protected]> * changing logger calls Signed-off-by: Dennis Toepker <[email protected]> --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]> * fixed imports Signed-off-by: Dennis Toepker <[email protected]> --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]>
#1561) (#1572) * Alerting Enhancements: Alerting Comments (Experimental) (#1561) * initial commit, functional but needs refactoring Signed-off-by: Dennis Toepker <[email protected]> * refactored QueryLevelTriggerExecutionContext to not need both Alert and AlertContext field, but only AlertContext field Signed-off-by: Dennis Toepker <[email protected]> * misc additions and fixes Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup Signed-off-by: Dennis Toepker <[email protected]> * misc changes and basic ITs Signed-off-by: Dennis Toepker <[email protected]> * cleanup Signed-off-by: Dennis Toepker <[email protected]> * renaming notes to comments Signed-off-by: Dennis Toepker <[email protected]> * misc changes Signed-off-by: Dennis Toepker <[email protected]> * changed API endpoints Signed-off-by: Dennis Toepker <[email protected]> * more misc changes and fixes Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup Signed-off-by: Dennis Toepker <[email protected]> * updated a comment Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup and setting refresh policy to immediate Signed-off-by: Dennis Toepker <[email protected]> * fixed lint issues and other restructuring Signed-off-by: Dennis Toepker <[email protected]> * review-based changes Signed-off-by: Dennis Toepker <[email protected]> * update after adding entityType to Comment model Signed-off-by: Dennis Toepker <[email protected]> * misc fixes Signed-off-by: Dennis Toepker <[email protected]> * removing comments history enabled setting Signed-off-by: Dennis Toepker <[email protected]> * adding release notes Signed-off-by: Dennis Toepker <[email protected]> * IT fixes Signed-off-by: Dennis Toepker <[email protected]> * removing dev code vestiges Signed-off-by: Dennis Toepker <[email protected]> * changing logger calls Signed-off-by: Dennis Toepker <[email protected]> --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]> * fixed imports Signed-off-by: Dennis Toepker <[email protected]> --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]> (cherry picked from commit f52eb2a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#1561) (#1572) (#1573) * Alerting Enhancements: Alerting Comments (Experimental) (#1561) * initial commit, functional but needs refactoring * refactored QueryLevelTriggerExecutionContext to not need both Alert and AlertContext field, but only AlertContext field * misc additions and fixes * misc cleanup * misc changes and basic ITs * cleanup * renaming notes to comments * misc changes * changed API endpoints * more misc changes and fixes * misc cleanup * updated a comment * misc cleanup and setting refresh policy to immediate * fixed lint issues and other restructuring * review-based changes * update after adding entityType to Comment model * misc fixes * removing comments history enabled setting * adding release notes * IT fixes * removing dev code vestiges * changing logger calls --------- * fixed imports --------- (cherry picked from commit f52eb2a) Signed-off-by: Dennis Toepker <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Dennis Toepker <[email protected]>
CIs have been fixed and merged in this followup PR: #1574 |
Issue #, if available:
#1500
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.