[Backport 2.x] Alerting Enhancements: Alerting Comments (Experimental) (#1561) #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit, functional but needs refactoring Signed-off-by: Dennis Toepker <[email protected]> * refactored QueryLevelTriggerExecutionContext to not need both Alert and AlertContext field, but only AlertContext field Signed-off-by: Dennis Toepker <[email protected]> * misc additions and fixes Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup Signed-off-by: Dennis Toepker <[email protected]> * misc changes and basic ITs Signed-off-by: Dennis Toepker <[email protected]> * cleanup Signed-off-by: Dennis Toepker <[email protected]> * renaming notes to comments Signed-off-by: Dennis Toepker <[email protected]> * misc changes Signed-off-by: Dennis Toepker <[email protected]> * changed API endpoints Signed-off-by: Dennis Toepker <[email protected]> * more misc changes and fixes Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup Signed-off-by: Dennis Toepker <[email protected]> * updated a comment Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup and setting refresh policy to immediate Signed-off-by: Dennis Toepker <[email protected]> * fixed lint issues and other restructuring Signed-off-by: Dennis Toepker <[email protected]> * review-based changes Signed-off-by: Dennis Toepker <[email protected]> * update after adding entityType to Comment model Signed-off-by: Dennis Toepker <[email protected]> * misc fixes Signed-off-by: Dennis Toepker <[email protected]> * removing comments history enabled setting Signed-off-by: Dennis Toepker <[email protected]> * adding release notes Signed-off-by: Dennis Toepker <[email protected]> * IT fixes Signed-off-by: Dennis Toepker <[email protected]> * removing dev code vestiges Signed-off-by: Dennis Toepker <[email protected]> * changing logger calls Signed-off-by: Dennis Toepker <[email protected]> --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]>
|
As per this comment, CI Failures will be addressed at a later time: #1561 (comment). The failing tests, |
Signed-off-by: Dennis Toepker <[email protected]>
jowg-amazon
approved these changes
Jun 12, 2024
AWSHurneyt
approved these changes
Jun 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
#1561) (#1572) * Alerting Enhancements: Alerting Comments (Experimental) (#1561) * initial commit, functional but needs refactoring Signed-off-by: Dennis Toepker <[email protected]> * refactored QueryLevelTriggerExecutionContext to not need both Alert and AlertContext field, but only AlertContext field Signed-off-by: Dennis Toepker <[email protected]> * misc additions and fixes Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup Signed-off-by: Dennis Toepker <[email protected]> * misc changes and basic ITs Signed-off-by: Dennis Toepker <[email protected]> * cleanup Signed-off-by: Dennis Toepker <[email protected]> * renaming notes to comments Signed-off-by: Dennis Toepker <[email protected]> * misc changes Signed-off-by: Dennis Toepker <[email protected]> * changed API endpoints Signed-off-by: Dennis Toepker <[email protected]> * more misc changes and fixes Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup Signed-off-by: Dennis Toepker <[email protected]> * updated a comment Signed-off-by: Dennis Toepker <[email protected]> * misc cleanup and setting refresh policy to immediate Signed-off-by: Dennis Toepker <[email protected]> * fixed lint issues and other restructuring Signed-off-by: Dennis Toepker <[email protected]> * review-based changes Signed-off-by: Dennis Toepker <[email protected]> * update after adding entityType to Comment model Signed-off-by: Dennis Toepker <[email protected]> * misc fixes Signed-off-by: Dennis Toepker <[email protected]> * removing comments history enabled setting Signed-off-by: Dennis Toepker <[email protected]> * adding release notes Signed-off-by: Dennis Toepker <[email protected]> * IT fixes Signed-off-by: Dennis Toepker <[email protected]> * removing dev code vestiges Signed-off-by: Dennis Toepker <[email protected]> * changing logger calls Signed-off-by: Dennis Toepker <[email protected]> --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]> * fixed imports Signed-off-by: Dennis Toepker <[email protected]> --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]> (cherry picked from commit f52eb2a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon
pushed a commit
that referenced
this pull request
Jun 12, 2024
#1561) (#1572) (#1573) * Alerting Enhancements: Alerting Comments (Experimental) (#1561) * initial commit, functional but needs refactoring * refactored QueryLevelTriggerExecutionContext to not need both Alert and AlertContext field, but only AlertContext field * misc additions and fixes * misc cleanup * misc changes and basic ITs * cleanup * renaming notes to comments * misc changes * changed API endpoints * more misc changes and fixes * misc cleanup * updated a comment * misc cleanup and setting refresh policy to immediate * fixed lint issues and other restructuring * review-based changes * update after adding entityType to Comment model * misc fixes * removing comments history enabled setting * adding release notes * IT fixes * removing dev code vestiges * changing logger calls --------- * fixed imports --------- (cherry picked from commit f52eb2a) Signed-off-by: Dennis Toepker <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Dennis Toepker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial commit, functional but needs refactoring
refactored QueryLevelTriggerExecutionContext to not need both Alert and AlertContext field, but only AlertContext field
misc additions and fixes
misc cleanup
misc changes and basic ITs
cleanup
renaming notes to comments
misc changes
changed API endpoints
more misc changes and fixes
misc cleanup
updated a comment
misc cleanup and setting refresh policy to immediate
fixed lint issues and other restructuring
review-based changes
update after adding entityType to Comment model
misc fixes
removing comments history enabled setting
adding release notes
IT fixes
removing dev code vestiges
changing logger calls
Issue #, if available:
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.