Relax the join validation for Remote State publication #15471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/src/main/java/org/opensearch/cluster/node/DiscoveryNode.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/coordination/JoinTaskExecutor.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 366e344: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rajiv-kv
force-pushed
the
join-remote-state
branch
from
366e344
to
15ff668
Compare
|
❌ Gradle check result for 15ff668: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 6d0cb37: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rajiv-kv
force-pushed
the
join-remote-state
branch
from
6d0cb37
to
46da900
Compare
|
❌ Gradle check result for 46da900: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rajiv-kv
force-pushed
the
join-remote-state
branch
from
46da900
to
48a5373
Compare
|
❌ Gradle check result for 48a5373: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rajiv-kv
force-pushed
the
join-remote-state
branch
from
48a5373
to
edd2a46
Compare
rajiv-kv
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli and
sohami
as code owners
rajiv-kv
added a commit
to rajiv-kv/OpenSearch
that referenced
this pull request
Sep 4, 2024
… but only publication enabled (opensearch-project#15471) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
3 tasks
rajiv-kv
added a commit
to rajiv-kv/OpenSearch
that referenced
this pull request
Sep 4, 2024
… but only publication enabled (opensearch-project#15471) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
3 tasks
rajiv-kv
added a commit
to rajiv-kv/OpenSearch
that referenced
this pull request
Sep 4, 2024
… but only publication enabled (opensearch-project#15471) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
rajiv-kv
added a commit
to rajiv-kv/OpenSearch
that referenced
this pull request
Sep 4, 2024
… but only publication enabled (opensearch-project#15471) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
rajiv-kv
added a commit
to rajiv-kv/OpenSearch
that referenced
this pull request
Sep 4, 2024
… but only publication enabled (opensearch-project#15471) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
rajiv-kv
added a commit
to rajiv-kv/OpenSearch
that referenced
this pull request
Sep 4, 2024
… but only publication enabled (opensearch-project#15471) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
shwetathareja
pushed a commit
that referenced
this pull request
Sep 4, 2024
… but only publication enabled (#15471) (#15667) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
shwetathareja
pushed a commit
that referenced
this pull request
Sep 5, 2024
… but only publication enabled (#15471) (#15675) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
This was referenced Sep 6, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
… but only publication enabled (opensearch-project#15471) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
This was referenced Sep 11, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
… but only publication enabled (opensearch-project#15471) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
… but only publication enabled (opensearch-project#15471) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
… but only publication enabled (opensearch-project#15471) Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
For Remote Store clusters, there is validation which ensures that remote attributes are either present / absent in all the nodes in cluster. However for clusters where only remote publication is enabled, this need not be enforced. ClusterManager ensures that the remote connecting node has publication enabled before publishing cluster-state updates[#15216 ]. Incase the remote node does not have publication enabled, it falls back to publish the cluster-state via transport
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.