Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relaxing the join validation for nodes which have only store disabled… #15667

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

rajiv-kv
Copy link
Contributor

@rajiv-kv rajiv-kv commented Sep 4, 2024

Backport :- #15471
… but only publication enabled (#15471)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for 7a2b56e: SUCCESS

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 81.08108% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.70%. Comparing base (ccae165) to head (8d4907e).
Report is 2 commits behind head on 2.17.

Files with missing lines Patch % Lines
...nsearch/cluster/coordination/JoinTaskExecutor.java 85.00% 1 Missing and 2 partials ⚠️
...nsearch/cluster/metadata/RepositoriesMetadata.java 80.00% 1 Missing and 1 partial ⚠️
...rch/node/remotestore/RemoteStoreNodeAttribute.java 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15667      +/-   ##
============================================
- Coverage     71.73%   71.70%   -0.04%     
- Complexity    64250    64268      +18     
============================================
  Files          5251     5251              
  Lines        300362   300397      +35     
  Branches      43704    43708       +4     
============================================
- Hits         215471   215385      -86     
- Misses        66908    66985      +77     
- Partials      17983    18027      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 1dad13b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

2 similar comments
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 1dad13b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 1dad13b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 1dad13b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for f7909c9: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

2 similar comments
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for f7909c9: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for f7909c9: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

… but only publication enabled (opensearch-project#15471)

Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❕ Gradle check result for 8d4907e: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants