-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When merging yaml files comments on the last element of existing block are placed at the wrong line #4671
Draft
jevanlingen
wants to merge
13
commits into
main
Choose a base branch
from
2218-mergeyamlvisitor-inline-comments-not-taken-into-account
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
When merging yaml files comments on the last element of existing block are placed at the wrong line #4671
jevanlingen
wants to merge
13
commits into
main
from
2218-mergeyamlvisitor-inline-comments-not-taken-into-account
Commits on Nov 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3419e41 - Browse repository at this point
Copy the full SHA 3419e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c2dc0c - Browse repository at this point
Copy the full SHA 8c2dc0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1845cf7 - Browse repository at this point
Copy the full SHA 1845cf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15b2336 - Browse repository at this point
Copy the full SHA 15b2336View commit details
Commits on Nov 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 42eb794 - Browse repository at this point
Copy the full SHA 42eb794View commit details -
Configuration menu - View commit details
-
Copy full SHA for f66d3a8 - Browse repository at this point
Copy the full SHA f66d3a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63c8d8e - Browse repository at this point
Copy the full SHA 63c8d8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d343297 - Browse repository at this point
Copy the full SHA d343297View commit details -
Configuration menu - View commit details
-
Copy full SHA for 652a1df - Browse repository at this point
Copy the full SHA 652a1dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5b0ed3 - Browse repository at this point
Copy the full SHA e5b0ed3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a50ae48 - Browse repository at this point
Copy the full SHA a50ae48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 841982c - Browse repository at this point
Copy the full SHA 841982cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2738e9 - Browse repository at this point
Copy the full SHA b2738e9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.