Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When merging yaml files comments on the last element of existing block are placed at the wrong line #4671

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

When merging yaml files comments on the last element of existing block are placed at the wrong line #4671

wants to merge 13 commits into from

Conversation

jevanlingen
Copy link
Contributor

@jevanlingen jevanlingen commented Nov 14, 2024 •
edited
Loading

What's changed?

After merge of two yam files, the comments will be placed at the right position.

What's your motivation?

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jevanlingen jevanlingen linked an issue Nov 14, 2024 that may be closed by this pull request
MergeYamlVisitor - inline comments not taken into account #2218
Open
@jevanlingen jevanlingen self-assigned this Nov 14, 2024
@jevanlingen jevanlingen added bug Something isn't working recipe Requested Recipe labels Nov 14, 2024
@jevanlingen jevanlingen changed the title 2218 mergeyamlvisitor inline comments not taken into account When merging yaml files comments on the last element of existing block are placed at the wrong line Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jevanlingen jevanlingen

Labels
bug Something isn't working recipe Requested Recipe
Projects
OpenRewrite
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MergeYamlVisitor - inline comments not taken into account
1 participant
@jevanlingen