Spherical bb

[caderache2014]

Description

This is a second attempt at adding the bounding box property to spherical meshes. The first (based on #2605) failed CI tests because the bounding box property itself was not added to the SphericalMesh class.

Fixes # (issue) #2605

Checklist

• I have performed a self-review of my own code
• I have run clang-format on any C++ source files (if applicable)
• I have followed the style guidelines for Python source files (if applicable)
• I have made corresponding changes to the documentation (if applicable)
• I have added tests that prove my fix is effective or that my feature works (if applicable)

[caderache2014]

@shimwell Hi John here's 2620. Yes it failed again. There was one line in which I wrote

bb = mesh.bounding_box()

Instead of....

bb = mesh.bounding_box

Obviously bounding_box is not callable. I fixed the code on my local repo, committed it to my branch spherical_bb and pushed to origin.

I don't see an option to either open a new pull request on the same branch nor rerun the same CI test on the updated pull request.

Should I .... make a new branch on my local repo (e.g. spherical_bb_2) and open a PR on that? There must be some way of re-running the CI tests...

-Chris

[caderache2014]

@shimwell Nevermind. i think i figured out how to re-issue the PR.

I'm working on getting Docker and everything installed on my Ubuntu-partitioned MacBook I so can run these tests locally and avoid these problems in the future

[shimwell]

Looks like the tests are passing but if you still want to run the test locally here is a command

pytest tests/unit_tests/test_mesh.py 

[caderache2014]

@shimwell Yes I did eventually figure that out. At first I was just navigating to /tests/ and running pytest. Since I don't have...docker and any number of necessary packages and libraries and virtual settings enabled it generate a lot of errors.
I did get docker set up on my laptop though ;-)

I've submitted another pull request for the cylindrical mesh as well.

[shimwell]

Suggested change

[paulromano]

Thanks for the PR @caderache2014. A few comments below:

[caderache2014]

@shimwell @paulromano cool