-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cylindrical bb #2621
Cylindrical bb #2621
Conversation
@shimwell yes I did notice the misspelling. I shouldn't have any problems running the unit tests locally in the future |
@shimwell can you tell if this test failed due to something beyond the remit of my changes? |
You are right, this CI error is beyond the remit of this PR. It looks like the nuclear data download is failing. Nothing for you to worry about. I can rerun the CI tomorrow and see if the download is working again |
Co-authored-by: Jonathan Shimwell <[email protected]>
@paulromano Cool! Thanks Dr Romano! |
Co-authored-by: Jonathan Shimwell <[email protected]> Co-authored-by: Paul Romano <[email protected]>
Description
Very similar changes to the changes in #2620. Add bounding box, upper_right, and lower_left properties to CylindricalMesh class. Added a unit test.
Checklist