-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document atlas language and directory map params #8
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
b1c40fc
to
748d4ee
Compare
c068633
to
3b75f0a
Compare
59917f5
to
6a035a0
Compare
df4cb4c
to
10f9d0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great overall! I left one little comment/question, but I'm extremely happy to see this kind of documentation!
atlas
Outdated
repository: <organization-name>/<repository-name> | ||
branch: <branch-name> | ||
directory: <repo-directory-name>:<local-dir-name> | ||
filter: ar de fr_CA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the configuration file documentation here uses descriptions instead of examples. Maybe something like
filter: ar de fr_CA | |
filter: <lang-code> |
would work? The only issue I have with using <lang-code>
is that the filter isn't technically language specific. I'm very open to other ideas for what to put here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Lang-code isn't what I prefer, but it's 99% of the time it'll just be that.
I added <pattern>
. Please see the latest force-push update for the rest of the changes.
Document new params: - --filter - --directory arg replacement Refs: FC-0012 OEP-58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This pull request is a documentation-only PR that I'll keep until all other PRs are merged. This helps to make incremental PRs faster while keeping documentation ready at the same time.
Documents new params:
Related PRs
This section is being updated to collect all related PRs:
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositories