Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document atlas language and directory map params #8

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Mar 30, 2023

Description

This pull request is a documentation-only PR that I'll keep until all other PRs are merged. This helps to make incremental PRs faster while keeping documentation ready at the same time.

Documents new params:

  • --dry-run (not included anymore)
  • --filter (for languages filtering)
  • --directory arg replacement

Related PRs

This section is being updated to collect all related PRs:

References

This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Check the links above for full information about the overall project.

Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:

  • Remove source and language translations from the repositories, hence no .json, .po or .mo files will be committed into the repos.
  • Add standardized make extract_translations in all repositories
  • Push user-facing messages strings into openedx/openedx-translations.
  • Integrate root repositories with openedx/openedx-atlas to pull translations on build/deploy time

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 30, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 30, 2023

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@OmarIthawi OmarIthawi changed the title feat: add languages parameter doc: document atlas language and directory map params Apr 5, 2023
@OmarIthawi OmarIthawi force-pushed the langs-param branch 2 times, most recently from b1c40fc to 748d4ee Compare April 5, 2023 21:23
@OmarIthawi OmarIthawi force-pushed the langs-param branch 2 times, most recently from c068633 to 3b75f0a Compare April 5, 2023 22:38
atlas Outdated Show resolved Hide resolved
atlas Outdated Show resolved Hide resolved
@OmarIthawi OmarIthawi force-pushed the langs-param branch 3 times, most recently from 59917f5 to 6a035a0 Compare April 6, 2023 03:55
@OmarIthawi OmarIthawi changed the title doc: document atlas language and directory map params docs: document atlas language and directory map params Apr 6, 2023
@OmarIthawi OmarIthawi force-pushed the langs-param branch 2 times, most recently from df4cb4c to 10f9d0e Compare April 11, 2023 13:27
@OmarIthawi OmarIthawi marked this pull request as ready for review April 11, 2023 13:27
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great overall! I left one little comment/question, but I'm extremely happy to see this kind of documentation!

atlas Outdated
repository: <organization-name>/<repository-name>
branch: <branch-name>
directory: <repo-directory-name>:<local-dir-name>
filter: ar de fr_CA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the configuration file documentation here uses descriptions instead of examples. Maybe something like

Suggested change
filter: ar de fr_CA
filter: <lang-code>

would work? The only issue I have with using <lang-code> is that the filter isn't technically language specific. I'm very open to other ideas for what to put here.

Copy link
Member Author

@OmarIthawi OmarIthawi Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Lang-code isn't what I prefer, but it's 99% of the time it'll just be that.

I added <pattern>. Please see the latest force-push update for the rest of the changes.

Document new params:

 - --filter
 - --directory arg replacement

Refs: FC-0012 OEP-58
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! :shipit:

@brian-smith-tcril brian-smith-tcril merged commit 4053454 into openedx:main Apr 11, 2023
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants