-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --dry-run command to print tree without copying files #11
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
818e329
to
5afb809
Compare
After thinking through the use cases I'm not sure if tying tree printing to a dry run makes sense. I can imagine a few use cases:
I think the simplest way to handle 2 and 3 would be to add Handling use case 1 is a little more complex, as ideally the flow would be:
Building out the logic for case 1 feels out of scope for this PR, but separating the logic for |
I'll push an update splitting the two options, without an interactive mode.
Did you mean |
Usage `$ atlas pull --dry-run` would print the following: - `git sparse-checkout` configuration - `git checkout` tree - `cp -r` tree Using this command won't copy the files into local directory. Refs: OEP-58 FC-0012
Good catch, yes. Skipping the file copy and going straight to the remove temp directory part makes sense. |
To avoid inflating the project scope. I'm going to close this PR for now as I focus on integrating atlas and documented the features into issues: |
@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Usage
$ atlas pull --dry-run
would print the following:git sparse-checkout
configurationgit checkout
treecp -r
treeFull docs are in #8.
Using this command won't copy the files into local directory.
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes.