Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused translations Make targets #1186

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: remove unused translations Make targets #1186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.PHONY: help upgrade requirements clean quality requirements \
requirements-test coverage pii_check \
compile_translations dummy_translations extract_translations \
fake_translations pull_translations push_translations test test-python \
fake_translations test test-python \
test-js quality-python quality-js

.DEFAULT_GOAL := help
Expand Down Expand Up @@ -122,22 +122,16 @@ diff_cover: test

## Localization targets

extract_translations: ## extract strings to be translated, outputting .mo files
extract_translations: ## extract strings to be translated, outputting .po files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this pair of comments is incorrect. makemessages generates .po files, and compilemessages runs over the .po files and generates .mo files.

cd edx_proctoring && django-admin makemessages -l en -v1 -d django
cd edx_proctoring && django-admin makemessages -l en -v1 -d djangojs

compile_translations: ## compile translation files, outputting .po files for each supported language
compile_translations: ## compile translation files, outputting .mo files for each supported language
cd edx_proctoring && django-admin compilemessages

detect_changed_source_translations:
cd edx_proctoring && i18n_tool changed

pull_translations: ## pull translations from Transifex
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to only be being used by the push and pull Transifex ecommerce scripts.

tx pull -a -f -t --mode reviewed --minimum-perc=1

push_translations: ## push source translation files (.po) from Transifex
tx push -s

validate_translations: ## Test translation files
cd edx_proctoring && i18n_tool validate -v

Expand Down
Loading