fix: remove unused translations Make targets #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelRoytman
commented
Feb 9, 2024
| @@ -122,22 +122,16 @@ diff_cover: test | |||
|
|
|||
| ## Localization targets | |||
|
|
|||
| extract_translations: ## extract strings to be translated, outputting .mo files | |||
| extract_translations: ## extract strings to be translated, outputting .po files | |||
There was a problem hiding this comment.
I believe this pair of comments is incorrect. makemessages generates .po files, and compilemessages runs over the .po files and generates .mo files.
MichaelRoytman
commented
Feb 9, 2024
| cd edx_proctoring && django-admin compilemessages | ||
|
|
||
| detect_changed_source_translations: | ||
| cd edx_proctoring && i18n_tool changed | ||
|
|
||
| pull_translations: ## pull translations from Transifex |
There was a problem hiding this comment.
This appears to only be being used by the push and pull Transifex ecommerce scripts.
zacharis278
approved these changes
Feb 13, 2024
edx_proctoring/__init__.py
Outdated
| @@ -3,4 +3,4 @@ | |||
| """ | |||
|
|
|||
| # Be sure to update the version number in edx_proctoring/package.json | |||
| __version__ = '4.16.1' | |||
| __version__ = '4.16.2' | |||
There was a problem hiding this comment.
if we're version bumping, can you put this in the changelog so there's an entry for 4.16.2? (alternatively we could just not version this)
There was a problem hiding this comment.
Yeah, I forgot to save and commit the CHANGELOG, but I'll just not version this change.
The edx-proctoring translations job has been removed. This commit removes the push_translations and pull_translations Make targets, which are no longer in use. Please see OEP-58: https://docs.openedx.org/en/latest/developers/concepts/oep58.html.
MichaelRoytman
force-pushed
the
michaelroytman/COSMO-162-translations-job-removal-clean-up
branch
from
d3cb9c9 to
9a7e084
Compare
MichaelRoytman
deleted the
michaelroytman/COSMO-162-translations-job-removal-clean-up
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
edx-proctoringtranslations job has been removed. This commit removes thepush_translationsandpull_translationsMake targets, which are no longer in use.Please see OEP-58.
JIRA: COSMO-162
Pre-Merge Checklist:
edx_proctoring/__init__.pyandpackage.jsonif these changes are to be released.CHANGELOG.rstPost-Merge: