Issue1337 temperature setpoint partial zone #1391
Conversation
… one for design heat loss)
…interfaces by variables or parameters
There was a problem hiding this comment.
@annadellisola @jelgerjansen thanks for addressing this issue! It's already looking great. I have added a few comments.
| @@ -169,11 +176,18 @@ to enable an input for a prescribed boundary condition temperature or heat flow | |||
| Alternatively, parameters <code>use_T_fixed</code> and <code>T_fixed</code> can be used | |||
| to specify a fixed boundary condition temperature. | |||
| It is not allowed to enabled multiple of these three options. | |||
| If all are disabled then an adiabatic boundary (<code>Q_flow=0</code>) is used. | |||
| If all are disabled then an adiabatic boundary (<code>Q_flow=0</code>) is used.</p> | |||
There was a problem hiding this comment.
| If all are disabled then an adiabatic boundary (<code>Q_flow=0</code>) is used.</p> | |
| If all are disabled, an adiabatic boundary (<code>Q_flow=0</code>) is used.</p> |
There was a problem hiding this comment.
I am a bit confused with all booleans, i.e. use_T_in and use_T_fixed. It is one or the other (this is specified in the documentation), so I suggest removing one of the two. Also, now the documentation string for both booleans is the same, which is not correct. If one of the booleans is removed, the assert statement can be simplified.
There was a problem hiding this comment.
Apparently, use_T_fixed and use_T_in have different functions, i.e. for the boundary wall and for the heat design calculation respectively. use_T_in and use_Q_in should be moved to the Advanced > Design power tab.
| @@ -64,6 +69,8 @@ protected | |||
| IDEAS.Buildings.Components.Interfaces.WeaBus weaBus(final numSolBus=sim.numIncAndAziInBus, | |||
| outputAngles=sim.outputAngles) "Weather bus" | |||
| annotation (Placement(transformation(extent={{40,-80},{60,-60}}))); | |||
| initial equation | |||
| QTra_design=if use_T_in or use_T_fixed then U_value*A*(TRefZon - T_in_nom) else -Q_in_nom; | |||
There was a problem hiding this comment.
TRefZon is determined in the bus connector and equals the reference zone temperature. T_in_nom is a parameter defined in this model and equals T_fixed. But in the case of use_T_fixed = False and use_T_in= True, T_in_nom should be T_in, right?
| @@ -504,7 +508,9 @@ end for; | |||
| connect(setq50.use_custom_n50s, propsBusInt.use_custom_n50) annotation (Line(points={{-60.8, | |||
| -92.8},{-60,-92.8},{-60,-92},{-80.1,-92},{-80.1,39.9}}, color={ | |||
| 255,0,255})); | |||
| annotation (Placement(transformation(extent={{ | |||
| connect(TRefZon.y, propsBusInt.TRefZon); | |||
| annotation (Dialog(group="Design heat load", tab="Advanced"), | |||
There was a problem hiding this comment.
Why is this Dialog(group="Design heat load", tab="Advanced") in the general annotation of the model? Can be removed, I guess.
| @@ -41,7 +41,7 @@ protected | |||
| if sim.interZonalAirFlowType <> IDEAS.BoundaryConditions.Types.InterZonalAirFlow.None | |||
| "Mass flow rate multiplier for port 1" | |||
| annotation (Placement(transformation(extent={{-10,-170},{10,-150}}))); | |||
| Modelica.Blocks.Math.Gain QTra_desgin(k=k) "Design heat flow rate" | |||
| Modelica.Blocks.Math.Gain QTra_design(k=k) "Design heat flow rate" | |||
| dT_nominal_a=-1, | ||
| add_cracks=false, | ||
| QTra_design(fixed=false), |
There was a problem hiding this comment.
QTra_design can currently be modified by the users via the parameter dialogue window. We might set this as a final or protected parameter that the user cannot change this value.
There was a problem hiding this comment.
same comment for other components (internal wall, outer wall, ...)
| @@ -141,6 +139,8 @@ public | |||
| if hasCavity and sim.interZonalAirFlowType == IDEAS.BoundaryConditions.Types.InterZonalAirFlow.OnePort | |||
| "1-port model for open door" | |||
| annotation (Placement(transformation(extent={{-10,58},{10,78}}))); | |||
| initial equation | |||
| QTra_design=U_value*A*(TRefZon - TRef_b); | |||
There was a problem hiding this comment.
TRefZon refers to TRefZon in propsBusA. Maybe a small documentation string might be instructive for other users, explaining that TRef_b is linked to propsBusB and TRefZon to propsBusA.
| connect(outsideAir.TDryBul_in, shaType.TDryBul) annotation( | ||
| Line(points = {{-42, -90}, {-46, -90}, {-46, -48}, {-58, -48}}, color = {0, 0, 127})); | ||
| connect(outsideAir.TDryBul_in, shaType.TDryBul) annotation ( | ||
| Line(points={{-42,-90},{-46,-90},{-46,-49.4895},{-57.5,-49.4895}}, |
There was a problem hiding this comment.
| Line(points={{-42,-90},{-46,-90},{-46,-49.4895},{-57.5,-49.4895}}, | |
| Line(points={{-42,-90},{-46,-90},{-46,-48},{-58,-48}}, |
Ideally, these types of changes are avoided... (at least, when they are not intended).
This PR addresses issue #1337.