issue1337_Changing T_setpoint in PartialZone and PartialSurface for Heat Losses Calculation #1380
Conversation
|
This PR addresses issue #1337 |
There was a problem hiding this comment.
@annadellisola thanks for implementing this. While revising, I noticed the existence of TRef_a which could also be used for design heat loss calculations. This avoids adding a new parameter.
| @@ -30,6 +30,10 @@ partial model PartialSurface "Partial model for building envelope component" | |||
| parameter Modelica.Units.SI.Temperature TRef_a=291.15 | |||
| "Reference temperature of zone on side of propsBus_a, for calculation of design heat loss" | |||
| annotation (Dialog(group="Design power", tab="Advanced")); | |||
| parameter Modelica.Units.SI.Temperature TSet=273.15+21 | |||
There was a problem hiding this comment.
Maybe TZonSet, TSetDes(, or TZonSetDes) might be slightly clearer (redundant if we use TRef_a).
Furthermore, if you set a temperature parameter, please use 293.15 instead of 273.15+21, because the dialog pane of the components typically displays temperatures in °C, which leads to (273.15 + 21) - 273.15 in your implementation (Dymola doesn't automatically computes this, I think because of the brackets' instead of 21.
| @@ -30,6 +30,10 @@ partial model PartialSurface "Partial model for building envelope component" | |||
| parameter Modelica.Units.SI.Temperature TRef_a=291.15 | |||
| "Reference temperature of zone on side of propsBus_a, for calculation of design heat loss" | |||
| annotation (Dialog(group="Design power", tab="Advanced")); | |||
| parameter Modelica.Units.SI.Temperature TSet=273.15+21 | |||
| "Reference temperature setpoint of zone (in K), for calculation of design heat loss" | |||
There was a problem hiding this comment.
You don't need to mention the (in K) part as Modelica always uses SI units (thus Kelvin). It's true that you can change the displayUnit to °C, but internally Modelica always uses Kelvin.
IDEAS/Buildings/Components/Window.mo
Outdated
| color = {0, 0, 127})); | ||
| connect(outsideAir.TDryBul_in, shaType.TDryBul) annotation( | ||
| Line(points = {{-42, -90}, {-46, -90}, {-46, -48}, {-58, -48}}, color = {0, 0, 127})); | ||
| connect(outsideAir.TDryBul_in, shaType.TDryBul) annotation ( | ||
| Line(points={{-42,-90},{-46,-90},{-46,-49.4895},{-57.5,-49.4895}}, | ||
| color = {0, 0, 127})); |
There was a problem hiding this comment.
This is a GUI change which seems unintended. Could you change it back to the original one?
If this doesn't work in Dymola, you can use a text editor as well to only change the desired code.
… one for design heat loss)
|
The final implementation is addressed in PR #1391 |
parameter Modelica.Units.SI.Temperature T_setpoint=273.15+21 "Reference temperature setpoint of zone (in K), for calculation of design heat loss";
final parameter Modelica.Units.SI.Power QInf_design=10121.204V/3600n50_int
/n50toAch(T_setpoint - sim.Tdes)
"Design heat losses from infiltration at reference outdoor temperature";
parameter Real fRH=11
"Reheat factor for calculation of design heat load, (EN 12831, table D.10 Annex D)" annotation(Dialog(tab="Advanced",group="Design heat load"))
final parameter Modelica.Units.SI.Power QRH_design=A*fRH
"Additional power required to compensate for the effects of intermittent heating";
Modelica.Units.SI.Power QTra_design=sum(propsBusInt.QTra_design)
"Total design transmission heat losses for the zone";
IDEAS.Buildings.Components.Interfaces.PartialSurface
parameter Modelica.Units.SI.Temperature TRef_a=291.15
"Reference temperature of zone on side of propsBus_a, for calculation of design heat loss"
annotation (Dialog(group="Design power", tab="Advanced"));
parameter Modelica.Units.SI.Temperature T_setpoint=273.15+21
"Reference temperature setpoint of zone (in K), for calculation of design heat loss"
annotation (Dialog(group="Design power", tab="Advanced"));
IDEAS.Buildings.Components.InternalWall → didn’t change it
final QTra_design=U_valueA(TRef_a - TRef_b)
parameter Modelica.Units.SI.Temperature TRef_b=291.15
"Reference temperature of zone on side of propsBus_b, for calculation of design heat loss"
annotation (Dialog(group="Design power", tab="Advanced"));
IDEAS.Buildings.Components.BoundaryWall
QTra_design=U_valueA(T_setpoint - TRef_a);
IDEAS.Buildings.Components.OuterWall
QTra_design =U_valueA(T_setpoint - Tdes.y);
Modelica.Blocks.Routing.RealPassThrough Tdes "Design temperature passthrough";
IDEAS.Buildings.Components.SlabOnGround
QTra_design=UEquiA(T_setpoint - sim.Tdes);
IDEAS.Buildings.Components.Window
QTra_design = (U_value*A + (if fraType.briTyp.present then fraType.briTyp.G else 0)) *(T_setpoint - Tdes.y);