annotate oci layers with component information #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianburth
force-pushed
the
oci-comp-annotation
branch
3 times, most recently
from
a15636d to
c94ab86
Compare
mandelsoft
previously approved these changes
Sep 2, 2024
fabianburth
force-pushed
the
oci-comp-annotation
branch
from
54c5dc0 to
5e5d5ec
Compare
|
Maybe, you could also add this spec to the Mapping spec of OCM to OCI Registries. |
mandelsoft
approved these changes
Sep 2, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
@maximilianbraun a very quick and dirty and in no way production ready experiment to annotate the oci layers with component information.
Since currently, the abstraction in code is intended to add all kinds of blobs to all kinds of storage backends, a clean solution would require several adjustments. A quick solution could introduce further options containing such metadata. Then the different storage implementation could choose whether to use or ignore those metadata. Furthermore, we might also want more metadata (e.g. to distinct sources from resources and to also annotate the descriptor layer itself).
Which issue(s) this PR fixes