Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable upload handler to annotate artifacts #190

Closed
9 tasks
fabianburth opened this issue May 16, 2024 · 4 comments · Fixed by open-component-model/ocm#987
Closed
9 tasks

Enable upload handler to annotate artifacts #190

fabianburth opened this issue May 16, 2024 · 4 comments · Fixed by open-component-model/ocm#987
Labels
component/ocm-core Open Component Model Core aka. go API kind/task small task, normally part of feature or epic

Comments

@fabianburth
Copy link

Description
For traceability reasons, it might be a useful feature to annotate e.g. oci artifacts with the component version identity. This feature should probably be toggle-able.

Done Criteria

  • ...
  • Code has been reviewed by other team members
  • Internal technical Documentation created/updated
  • New / changed code is documented
  • Analysis of existing tests (Unit and Integration)
  • Unit Tests created for new code or existing Unit Tests updated
  • Integration Test Suite updated (includes deletion of existing unnecessary Integration Test and/or creation of new ones if required)
  • Enduser Documentation updated (if applicable)
  • Successful demonstration in Review
@fabianburth fabianburth added the kind/task small task, normally part of feature or epic label May 16, 2024
@fabianburth fabianburth moved this from 🆕 ToDo to 📋 Next-UP in OCM Backlog Board May 16, 2024
@fabianburth fabianburth moved this from 📋 Next-UP to 🆕 ToDo in OCM Backlog Board May 16, 2024
@morri-son morri-son added the component/ocm-core Open Component Model Core aka. go API label Jun 3, 2024
@morri-son morri-son moved this from 🆕 ToDo to 📋 Next-UP in OCM Backlog Board Jun 3, 2024
@morri-son morri-son moved this from 📋 Next-UP to 🆕 ToDo in OCM Backlog Board Jul 11, 2024
@morri-son
Copy link
Contributor

@mandelsoft , can you please check this and note things that have already been implemented?

@morri-son
Copy link
Contributor

fixed by open-component-model/ocm#882

@github-project-automation github-project-automation bot moved this from 🆕 ToDo to 🍺 Done in OCM Backlog Board Oct 18, 2024
@mandelsoft
Copy link

I did nothing, we already annotated layers with the resource identity, but not the OCI manifest itself

@mandelsoft
Copy link

open-component-model/ocm#987

@mandelsoft mandelsoft mentioned this issue Oct 18, 2024
Merged
mandelsoft added a commit to open-component-model/ocm that referenced this issue Oct 23, 2024
@mandelsoft
!OCI Annotations change in Component Descriptor for Component Version…
71d79e4 
…s: `ocm-artifact` -> `software.ocm.artifact` and introduce `software.ocm.creator` (#987)

<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it

For OCM repositories based on OCI registries, the manifest now gets an
annotation `software.ocm.componentversion` with the component version it
represents.

The image spec
(https://github.com/opencontainers/image-spec/blob/main/annotations.md)
state, that annotation names should use a reverse DNS domain prefix.

Therefore we should adapt the names of the already existing layer
annotations accordingly. This PR prepends the actuals names with
`software.ocm.".

The old layer annotation changes from `ocm-artifact` ->
`software.ocm.artifact`.

#### Which issue(s) this PR fixes
Fixes open-component-model/ocm-project#190
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
@ocmbot ocmbot bot moved this from 🍺 Done to 🔒Closed in OCM Backlog Board Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/ocm-core Open Component Model Core aka. go API kind/task small task, normally part of feature or epic
Projects
OCM Backlog Board
Status: 🔒Closed
Milestone
No milestone
3 participants
@mandelsoft @fabianburth @morri-son