-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appsub status reference to subcription CRD #133
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: philipwu08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You might have to run the code gen for the new field. But there is a problem with the code gen make target right now. |
5b2ab27
to
0c1db99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philipwu08 It may be safer to just append the new changes including the new AppstatusReference field and the new SubscriptionState name to the existing subscription CRD.
The current subscription CRD has some manual changes like the x-kubernetes-preserve-unknown-fields: true
property added on some byte fields, The automatically generated CRD won't have them.
type: object | ||
x-kubernetes-preserve-unknown-fields: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all x-kubernetes-preserve-unknown-fields: true
are required. Or the clusterOverride won't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks XJ. I went with the safest option which is updating the existing CRD with specific changes instead of using the generated CRD.
I haven't problems access my clusters so the PR is on hold until I've verified the changes.
deploy/crds/apps.open-cluster-management.io_subscriptions_crd_v1.yaml
Outdated
Show resolved
Hide resolved
deploy/crds/apps.open-cluster-management.io_subscriptions_crd_v1.yaml
Outdated
Show resolved
Hide resolved
deploy/crds/apps.open-cluster-management.io_subscriptions_crd_v1.yaml
Outdated
Show resolved
Hide resolved
/hold |
0c1db99
to
f6c2c15
Compare
Signed-off-by: Philip Wu <[email protected]>
f6c2c15
to
afc0979
Compare
/unhold |
Signed-off-by: Philip Wu <[email protected]>
/lgtm |
https://github.com/stolostron/backlog/issues/20331
Signed-off-by: Philip Wu [email protected]