Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appsub status reference to subcription CRD #133

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

philipwu08
Copy link
Collaborator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipwu08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikeshng
Copy link
Member

You might have to run the code gen for the new field. But there is a problem with the code gen make target right now.
See #131 for the workaround please.

Copy link
Collaborator

@xiangjingli xiangjingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philipwu08 It may be safer to just append the new changes including the new AppstatusReference field and the new SubscriptionState name to the existing subscription CRD.
The current subscription CRD has some manual changes like the x-kubernetes-preserve-unknown-fields: true property added on some byte fields, The automatically generated CRD won't have them.

type: object
x-kubernetes-preserve-unknown-fields: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all x-kubernetes-preserve-unknown-fields: true are required. Or the clusterOverride won't work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks XJ. I went with the safest option which is updating the existing CRD with specific changes instead of using the generated CRD.

I haven't problems access my clusters so the PR is on hold until I've verified the changes.

@philipwu08
Copy link
Collaborator Author

/hold

@philipwu08
Copy link
Collaborator Author

/unhold

@xiangjingli
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 210b24a into main Mar 23, 2022
@xiangjingli xiangjingli deleted the status-reference branch March 23, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants