Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add appsub status reference to subcription CRD #701

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Add appsub status reference to subcription CRD #701

merged 2 commits into from
Mar 23, 2022

Conversation

philipwu08
Copy link
Contributor

@philipwu08
Copy link
Contributor Author

/test test-unit

@mikeshng
Copy link
Contributor

It might be missing code gen changes? Same comment here open-cluster-management-io/multicloud-operators-subscription#133 (comment)

@philipwu08
Copy link
Contributor Author

/hold

@philipwu08
Copy link
Contributor Author

/unhold

xiangjingli
xiangjingli reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@xiangjingli xiangjingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philipwu08 BTW, after the PR is merged, I will create a new community CSV to bundle the new appsub CRD. I will let you know when the new community CSV is merged. You can verify this using a new ACM upstream build

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@xiangjingli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipwu08, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [philipwu08,xiangjingli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 08a9db5 into main Mar 23, 2022
@xiangjingli xiangjingli deleted the status-reference branch March 23, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangjingli xiangjingli xiangjingli left review comments

Assignees

@xiangjingli xiangjingli

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philipwu08 @mikeshng @xiangjingli @openshift-merge-robot