Fix: hidden individual upload-measurement toast (#531)

Fixes ooni/probe#2511, ooni/probe#2487 ## Proposed Changes - Updated constraints for UploadBarFooter
ooni · Oct 19, 2023 · 9602f41 · 9602f41
1 parent cfe9f0c
commit 9602f41
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 29 deletions.
diff --git a/ooniprobe/View/TestResults/Details/CircumventionDetailsViewController.m b/ooniprobe/View/TestResults/Details/CircumventionDetailsViewController.m
@@ -89,10 +89,7 @@ -(void)viewWillAppear:(BOOL)animated{
 }
 
 -(void)reloadConstraints{
-    CGFloat uploadConstraint = 0;
-    if ([RunningTest currentTest].isTestRunning){
-        uploadConstraint += 64;
-    }
+    CGFloat uploadConstraint = 64;
     dispatch_async(dispatch_get_main_queue(), ^{
         self.uploadBarFooterConstraint.constant = uploadConstraint;
     });

diff --git a/ooniprobe/View/TestResults/Details/DashDetailsViewController.m b/ooniprobe/View/TestResults/Details/DashDetailsViewController.m
@@ -35,10 +35,7 @@ -(void)viewWillAppear:(BOOL)animated{
 }
 
 -(void)reloadConstraints{
-    CGFloat uploadConstraint = 0;
-    if ([RunningTest currentTest].isTestRunning){
-        uploadConstraint += 64;
-    }
+    CGFloat uploadConstraint = 64;
     dispatch_async(dispatch_get_main_queue(), ^{
         self.uploadBarFooterConstraint.constant = uploadConstraint;
     });

diff --git a/ooniprobe/View/TestResults/Details/FailedTestDetailsViewController.m b/ooniprobe/View/TestResults/Details/FailedTestDetailsViewController.m
@@ -38,10 +38,7 @@ -(IBAction)reRun{
 }
 
 -(void)reloadConstraints{
-    CGFloat uploadConstraint = 0;
-    if ([RunningTest currentTest].isTestRunning){
-        uploadConstraint += 64;
-    }
+    CGFloat uploadConstraint = 64;
     dispatch_async(dispatch_get_main_queue(), ^{
         self.uploadBarFooterConstraint.constant = uploadConstraint;
     });

diff --git a/ooniprobe/View/TestResults/Details/InstantMessagingDetailsViewController.m b/ooniprobe/View/TestResults/Details/InstantMessagingDetailsViewController.m
@@ -109,10 +109,7 @@ -(void)viewWillAppear:(BOOL)animated{
 }
 
 -(void)reloadConstraints{
-    CGFloat uploadConstraint = 0;
-    if ([RunningTest currentTest].isTestRunning){
-        uploadConstraint += 64;
-    }
+    CGFloat uploadConstraint = 64;
     dispatch_async(dispatch_get_main_queue(), ^{
         self.uploadBarFooterConstraint.constant = uploadConstraint;
     });

diff --git a/ooniprobe/View/TestResults/Details/MiddleBoxesDetailsViewController.m b/ooniprobe/View/TestResults/Details/MiddleBoxesDetailsViewController.m
@@ -45,10 +45,7 @@ -(void)viewWillAppear:(BOOL)animated{
 }
 
 -(void)reloadConstraints{
-    CGFloat uploadConstraint = 0;
-    if ([RunningTest currentTest].isTestRunning){
-        uploadConstraint += 64;
-    }
+    CGFloat uploadConstraint = 64;
     dispatch_async(dispatch_get_main_queue(), ^{
         self.uploadBarFooterConstraint.constant = uploadConstraint;
     });

diff --git a/ooniprobe/View/TestResults/Details/NdtDetailsViewController.m b/ooniprobe/View/TestResults/Details/NdtDetailsViewController.m
@@ -59,10 +59,7 @@ -(void)viewWillAppear:(BOOL)animated{
 }
 
 -(void)reloadConstraints{
-    CGFloat uploadConstraint = 0;
-    if ([RunningTest currentTest].isTestRunning){
-        uploadConstraint += 64;
-    }
+    CGFloat uploadConstraint = 64;
     dispatch_async(dispatch_get_main_queue(), ^{
         self.uploadBarFooterConstraint.constant = uploadConstraint;
     });

diff --git a/ooniprobe/View/TestResults/Details/TestDetailsViewController.m b/ooniprobe/View/TestResults/Details/TestDetailsViewController.m
@@ -105,7 +105,7 @@ -(void)reloadFooter{
             [self.scrollView setNeedsUpdateConstraints];
         }
         else {
-            self.scrollViewFooterConstraint.constant = 0;
+            self.scrollViewFooterConstraint.constant = 64;
             [self.scrollView setNeedsUpdateConstraints];
         }
     });

diff --git a/ooniprobe/View/TestResults/Details/WebsitesDetailsViewController.m b/ooniprobe/View/TestResults/Details/WebsitesDetailsViewController.m
@@ -56,10 +56,7 @@ -(void)viewWillAppear:(BOOL)animated{
 }
 
 -(void)reloadConstraints{
-    CGFloat uploadConstraint = 0;
-    if ([RunningTest currentTest].isTestRunning){
-        uploadConstraint += 64;
-    }
+    CGFloat uploadConstraint = 64;
     dispatch_async(dispatch_get_main_queue(), ^{
         self.uploadBarFooterConstraint.constant = uploadConstraint;
     });