FI-2096 Add list of applicable options to 'Inferno Tests' sheet in test procedure matrix #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arscan
changed the title
arscan
force-pushed
the
options-in-matrix
branch
from
725075b
to
fce39eb
Compare
| runnable_and_parents = [runnable].tap do |parents| | ||
| while runnable.respond_to?(:parent) && | ||
| runnable.respond_to?(:suite_option_requirements) && | ||
| (runnable = runnable.parent) |
There was a problem hiding this comment.
Suggested change
| (runnable = runnable.parent) | |
| (runnable == runnable.parent) |
I'm assuming you're intending to do a comparison rather than an assignment here
There was a problem hiding this comment.
Nope, this is just bad code that i wrote quickly. This is what allowed the while loop to traverse upwards. I updated the code to be a bit simpler.
I'm not sure if this has to be this complicated though, I just wasn't sure how much options got pushed down to children in the test tree... so i just had it gather all relevant options for itself and all of its ancestors and then eventually do a 'uniq' to throw out any duplicates.
arscan
force-pushed
the
options-in-matrix
branch
from
0ded4a9
to
5475209
Compare
Jammjammjamm
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion about the content in the 'Inferno Tests' sheet because we don't indicate that some tests only apply to certain standards. This PR adds a column to that sheet with that information.
I originally just created it to send to drummond to help explain how that sheet works, but it seems to make sense to include it going forward.
If multiple options apply, they all will be listed. I suppose it would be nicer if we had a column per option, and then filled in that column with option value selected (if any), but that was a little more complicated and this conveys the same amount of information.
Run by doing
bundle exec rake g10_test_kit:generate_matrix