Improve applicable_options method for clarity.

onc-healthit · Aug 28, 2023 · 0ded4a9 · 0ded4a9
1 parent 5a2050f
commit 0ded4a9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/lib/onc_certification_g10_test_kit/tasks/generate_matrix.rb b/lib/onc_certification_g10_test_kit/tasks/generate_matrix.rb
@@ -191,10 +191,8 @@ def generate_test_procedure_worksheet # rubocop:disable Metrics/CyclomaticComple
       # returns an array of options that apply to this test or group
       def applicable_options(runnable)
         runnable_and_parents = [runnable].tap do |parents|
-          while runnable.respond_to?(:parent) &&
-                runnable.respond_to?(:suite_option_requirements) &&
-                (runnable = runnable.parent)
-            parents << runnable
+          while parents.last.parent.present?
+            parents << parents.last.parent
           end
         end
         runnable_and_parents.map(&:suite_option_requirements).compact.flatten

diff --git a/onc_certification_g10_matrix.xlsx b/onc_certification_g10_matrix.xlsx