Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for go1.16 #53

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Fix build for go1.16 #53

merged 3 commits into from
Jul 26, 2023

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented Jul 25, 2023

  • Fixed the dependencies for building the code against go1.16
  • Added go1.16 as a matrix target for the unit tests
  • Updated go.sum to have the correct version of the dependencies

* Fixed the dependencies for building the code against go1.16
* Added go1.16 as a matrix target for the unit tests
* Updated go.sum to have the correct version of the dependencies

Signed-off-by: Rodolfo Olivieri <[email protected]>
@r0x0d r0x0d self-assigned this Jul 25, 2023
@r0x0d r0x0d requested a review from andywaltlova July 25, 2023 18:15
Signed-off-by: Rodolfo Olivieri <[email protected]>
go.mod Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (281b85f) 61.16% compared to head (1401210) 61.16%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   61.16%   61.16%           
=======================================
  Files           5        5           
  Lines         327      327           
=======================================
  Hits          200      200           
  Misses        112      112           
  Partials       15       15           
Flag Coverage Δ
go-1.16 61.16% <ø> (?)
go-1.20 61.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d merged commit e0c5682 into oamg:main Jul 26, 2023
3 checks passed
@r0x0d r0x0d deleted the fix-build-for-go1.16 branch July 26, 2023 12:32
@r0x0d r0x0d mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants