Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grpc to newest v1.59.x version #101

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

andywaltlova
Copy link
Collaborator

@andywaltlova andywaltlova commented Oct 26, 2023

https://github.com/oamg/rhc-worker-script/security/dependabot/13

This needs to be tested for build in brew because last time we had problem with dependencies , see #53 (comment), it could work now because we bumped go to 1.19

It looks like this version of grpc is dependend on go 1.19 https://github.com/grpc/grpc-go/blob/v1.59.0/go.mod , and sys used in that is dependent on go 1.17 - tehrefore should work in theory or at if we have a problem it should be different one than before

@andywaltlova andywaltlova changed the title Fix grpc to neves v1.58.x version Fix grpc to newest v1.58.x version Oct 26, 2023
@andywaltlova
Copy link
Collaborator Author

@r0x0d could you take a look and help me test it? Should we do scratch build before merge if it works?

Signed-off-by: Andrea Waltlova <[email protected]>
@andywaltlova andywaltlova changed the title Fix grpc to newest v1.58.x version Fix grpc to newest v1.59.x version Oct 26, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d50e7b) 65.34% compared to head (179b274) 65.34%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   65.34%   65.34%           
=======================================
  Files           5        5           
  Lines         352      352           
=======================================
  Hits          230      230           
  Misses        101      101           
  Partials       21       21           
Flag Coverage Δ
go-1.19 65.34% <ø> (ø)
go-1.20 65.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d
Copy link
Member

r0x0d commented Oct 26, 2023

@r0x0d could you take a look and help me test it? Should we do scratch build before merge if it works?

Sure, I can get back to that next week. I have talked with the prodsec folks and seems that we are off the hook with this for the worker, so we don't have to rush.

@r0x0d
Copy link
Member

r0x0d commented Nov 1, 2023

I will merge this and we can test before the next build.

@r0x0d r0x0d merged commit c4108ed into oamg:main Nov 1, 2023
6 checks passed
@r0x0d r0x0d mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants