Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Windows ARM build #3385

Merged
merged 16 commits into from
Jan 21, 2025
Merged

add Windows ARM build #3385

merged 16 commits into from
Jan 21, 2025

Conversation

cebtenzzre
Copy link
Member

@cebtenzzre cebtenzzre commented Jan 14, 2025

This PR adds offline and online installer jobs in CI for the Windows ARM64 platform. They are able to produce signed installers that run on a Dell laptop with a Snapdragon processor.

Currently, no acceleration backends are enabled, so all inference is done on the CPU.

QtPDF is unavailable because it is part of QtWebEngine, which does not yet have a Windows ARM build. So on this platform, PDFium is used directly instead of via QtPDF. I have compared the resulting databases and verified that the contents are identical. You can enable PDFium on other platforms for testing purposes with -DGPT4ALL_USE_QTPDF=OFF. When this flag is specified, you should be able to build GPT4All on other platforms without installing QtWebEngine or QtPDF.

Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Since we don't install these, it's not useful to attempt to build them
when we are cross-compiling.

Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
@cebtenzzre cebtenzzre marked this pull request as ready for review January 15, 2025 20:40
@cebtenzzre
Copy link
Member Author

cebtenzzre commented Jan 15, 2025

I am currently testing the online installer build. The offline installer built in CI has been tested and works fine.

edit: It completed successfully.

@cebtenzzre cebtenzzre mentioned this pull request Jan 15, 2025
Copy link
Collaborator

@manyoso manyoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be unconflicted with the changes to CMakeLists.txt fixing cign maintenancetool.app on macOS.

@cebtenzzre cebtenzzre requested a review from manyoso January 21, 2025 16:32
@manyoso manyoso merged commit 810615d into main Jan 21, 2025
4 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants