-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Windows ARM build #3385
Merged
Merged
add Windows ARM build #3385
+474
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Since we don't install these, it's not useful to attempt to build them when we are cross-compiling. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
I am currently testing the online installer build. The offline installer built in CI has been tested and works fine. edit: It completed successfully. |
Merged
manyoso
approved these changes
Jan 21, 2025
manyoso
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be unconflicted with the changes to CMakeLists.txt fixing cign maintenancetool.app on macOS.
manyoso
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds offline and online installer jobs in CI for the Windows ARM64 platform. They are able to produce signed installers that run on a Dell laptop with a Snapdragon processor.
Currently, no acceleration backends are enabled, so all inference is done on the CPU.
QtPDF is unavailable because it is part of QtWebEngine, which does not yet have a Windows ARM build. So on this platform, PDFium is used directly instead of via QtPDF. I have compared the resulting databases and verified that the contents are identical. You can enable PDFium on other platforms for testing purposes with
-DGPT4ALL_USE_QTPDF=OFF
. When this flag is specified, you should be able to build GPT4All on other platforms without installing QtWebEngine or QtPDF.