Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Qt 6.8.1 #3386

Merged
merged 11 commits into from
Jan 24, 2025
Merged

Update to Qt 6.8.1 #3386

merged 11 commits into from
Jan 24, 2025

Conversation

cebtenzzre
Copy link
Member

@cebtenzzre cebtenzzre commented Jan 15, 2025

Qt 6.5.1 has been EOL for over a year. Update to Qt 6.8.1.

Closes #2975, which included more involved refactoring that was never completed. Untangling the copy-pasted CI scripts is probably not going to happen anytime soon.

Conflicts with #3385 until one of them is merged.

Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
@cebtenzzre cebtenzzre marked this pull request as ready for review January 15, 2025 21:08
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
- macOS has no debug_info anymore
- qt5compat is now addons.qt5compat
- gcc_64 is now linux_gcc_64

Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
- Update the Windows ARM build since it is new and also uses Qt 6.5.
- Remove the WINDEPLOYQT hack since it is no longer needed. Qt 6.8's ARM
  build provides windeployqt, so we don't need to force use of the
  native x86_64 one anymore.

Signed-off-by: Jared Van Bortel <[email protected]>
@cebtenzzre
Copy link
Member Author

I'm going to test the newly modified Windows ARM build before we merge this.

@cebtenzzre
Copy link
Member Author

The ARM build is missing the Qt libs. I forgot that although Qt 6.8 ships windeployqt in the cross-compiled ARM version, it's actually compiled as an ARM executable so it's unusable on the build machine. Will fix.

Signed-off-by: Jared Van Bortel <[email protected]>
@cebtenzzre
Copy link
Member Author

At first I thought my last commit didn't fix the issue, but upon further investigation it did. I had downloaded the wrong installer the first time.

@cebtenzzre cebtenzzre requested a review from manyoso January 21, 2025 22:00
@manyoso manyoso merged commit 173fdb1 into main Jan 24, 2025
14 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants