Add support for sub-region tile servers (local maps) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timple
reviewed
Dec 19, 2024
| std::string origin_crs; | ||
|
|
||
| // local map projection | ||
| PJ_CONTEXT * context = proj_context_create(); |
There was a problem hiding this comment.
Thanks for this PR!
Would you mind using smart pointers here?
There was a problem hiding this comment.
Thank you for your feedback on this pull request.
You could use smart pointers (potentially std::unique_ptr ), but objects of type TileMapInformation are passed into different functions. Thus, an explicit copy constructor would have to be defined for TileMapInformation. In addition, you would probably also define a custom destructor that calls special "cleanup" functions of the PROJ Lib.
Since the use of smart pointers has been largely avoided in the repository, I have not used them as well. But of course, we can discuss this again. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Feature: Support for Sub-Region Tile Servers
This pull request introduces a new feature allowing support for tile servers that provide maps for a specific sub-region rather than global coverage. This functionality is enabled via a new top-level property:
Use Local Map.Details
For tile servers covering only a specific sub-region, zoom levels and tile coverage may deviate from typical global tile maps. Thus, certain properties need to be configured manually. Specifically:
Refer to OpenStreetMap's guide on zoom levels for more context on how zoom levels affect tile size and coverage.
New Properties under
Use Local MapThe following properties are introduced to support configuration for local map servers:
Meter per Pixel (Zoom 0): Defines the length (in meters) of a pixel edge at zoom level 0. Default is0.0.Origin CRS: The EPSG code for the coordinate reference system (CRS) of the local origin. This should be a cartesian coordinate system. Default is not set.Origin X: The X-coordinate of the local origin in the specified CRS. Default is0.0.Origin Y: The Y-coordinate of the local origin in the specified CRS. Default is0.0.Additional Notes
Please review the "Example Usage" section in the
README.mdfor detailed usage examples and to verify integration with existing functionality.