Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made casting more explicit for better compatibility with different compilers #41

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

johan0A
Copy link
Contributor

@johan0A johan0A commented Oct 11, 2024

Made casting more explicit for better compatibility with different compilers. For instance zig cc was producing errors. And zig cc relies on some version of clang witch is probably also affected.

@nicbarker
Copy link
Owner

@johan0A Thanks a bunch for fixing these up, I don't generally test with zig cc so wouldn't have caught these 🙂
I will see if I can get the github CI to run a compile using zig cc, so I can avoid breaking these compilers in future.

@nicbarker nicbarker merged commit 05eb12b into nicbarker:main Oct 12, 2024
3 checks passed
@johan0A
Copy link
Contributor Author

johan0A commented Oct 13, 2024

@nicbarker That would be very cool :D Though to be clear clay.h does compile without errors using zig cc but using the affected functions produces illegal instruction errors.

@nicbarker
Copy link
Owner

@johan0A ah fascinating, good to know thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants