-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch biowulf config #696
Patch biowulf config #696
Conversation
Add restriction to prevent over-threading. Modify the cache names for nxf_singularity to separate it from singularity cache. Add restriction to prevent user's mis-usage of clusterOption in params.
The executor contents are moved inside of profile, so that it could run individually without cross-talking.
conf/biowulf.config
Outdated
} | ||
|
||
env { | ||
SINGULARITY_CACHEDIR="/data/$USER/singularity" | ||
SINGULARITY_CACHEDIR="/data/$USER/.singularity" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this, shouldn't this be the same as the path above?
so that is is more clear to be able to reuse in profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only seen them ever be the same.
So I think, make them match or reveal your secrets 😁
conf/biowulf.config
Outdated
} | ||
|
||
env { | ||
SINGULARITY_CACHEDIR="/data/$USER/singularity" | ||
SINGULARITY_CACHEDIR="/data/$USER/.singularity" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SINGULARITY_CACHEDIR="/data/$USER/.singularity" | |
SINGULARITY_CACHEDIR="/data/$USER/nxf_singularity_cache" |
move clusterOptions and scratch out of executor, and move them into process.
delete spaces
When solving the conflicts from the recent update on config file from nf-core side, the cachedir is reset to older version. Have to modify it to match our cluster setting.
Deleted the out of date one
Remove the out of dated resourcelimits from params to process. Changed the igenome_base from /fdb/igenomes to /fdb/igenomes_nf.
the recent update of cluster hardware.
There is bug in this setting, the time without .h will cause user's slurm job submitted with unlimited time, and the job will never got started since it excessed the wall time of slurm partition. Related commit: 32a6072#diff-96a1aad67f506874b7386e703c477b248b02e69624dbdaaa4ba7478d7b7d0f88
|
SINGULARITY_CACHEDIR in env has been removed, because it does not work as expected.
name: Update the cluster config
about: patches
Please follow these steps before submitting your PR:
master
branch