Tree component refactoring #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-victorlin-prep--fjlw4s
16 tasks
Using ReturnType on all sub-states except for controls (which already has a type to be used directly) and narrative (the compiler was not able to resolve types between return values and default state). The next commit will fix the narrative type.
victorlin
force-pushed
the
victorlin/prep-dynamic-yvalues
branch
from
9ecca22
to
8280aaa
Compare
victorlin
force-pushed
the
victorlin/prep-dynamic-yvalues
branch
from
8280aaa
to
33277b5
Compare
src/components/tree/tree.js
Outdated
| } | ||
|
|
||
| clearSelectedNode = () => { | ||
| callbacks.clearSelectedNode.bind(this); |
There was a problem hiding this comment.
[reminder to me] - check this change, I remember binding callbacks in the constructor was "the right way" way back when I was writing this code.
There was a problem hiding this comment.
I see:
auspice/src/components/map/map.js
Lines 84 to 85 in 3cd0c1e
|
@genehack could you take a look at the types added / used here if you have a chance? 🙏 |
This was necessary to properly type the root state. Note: AnyAction is used for `action` which is only slightly better than any. Ideally, each action type would come with its own TypeScript interface but there is no good way to tightly couple those. I think the right improvement here is to use Redux's createSlice but that is beyond the scope of adding types.
This allows type checking on the new entries.
This does not provide much benefit as-is, but should facilitate future usage of TypeScript within the component.
The commented out usage was removed in "Excise react-svg-pan-zoom" (56fbb8a).
Keep consistent with other parts of the file.
Only the clearSelectedNode binding needs to be kept in the constructor.
victorlin
force-pushed
the
victorlin/prep-dynamic-yvalues
branch
from
6d65167
to
ceec881
Compare
genehack
reviewed
Oct 9, 2024
- `treeIsZoomed` is ambiguous since the condition considers two trees. Rename to `anyTreeZoomed`. - `activeResetTreeButton` has the same condition as `anyTreeZoomed`. Reuse the existing variable.
Partial<ControlsState> previously worked but has the side effect of marking all keys as optional, which is not accurate and prone to cause future type errors.
victorlin
force-pushed
the
victorlin/prep-dynamic-yvalues
branch
from
ceec881
to
4658803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Changes made while prepping for #1373. These can be considered independently from that PR. See individual commit messages.
Checklist
If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PRno functional changes(to be done by a Nextstrain team member) Create preview PRs on downstream repositories.no functional changes