New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring #1874

Open

4 tasks

victorlin opened this issue Oct 21, 2024 · 0 comments

Assignees

Member

victorlin commented Oct 21, 2024

From @jameshadfield in #1863 (comment):

if you see stuff that is clearly poorly implemented it's probably because it was just a poor implementation. Please add a FIXME comment in the code or just fix it. I'd prefer inconsistent code over consistently bad code.

Tasks

Pass props to reducer functions as an object (ref)
Simplify function definitions (ref)
Rename variables that use "display order" terminology (ref)
- I'll plan to do this as part of Add tree-related types #1864
Rename tipCount as visibleTipCount (ref)
- I'll plan to do this as part of Add tree-related types #1864

The text was updated successfully, but these errors were encountered:

victorlin self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment