Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fx(dav): file request guest nickname encoding #49226

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fx(dav): file request guest nickname encoding #49226

merged 2 commits into from
Nov 12, 2024

Conversation

skjnldsv
Copy link
Member

Fix #48942

Steps

  1. Create a file request
  2. Access the file request URI
  3. Enter a guest name with an umlaut Mörris
  4. Upload a file and see a 500 request

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 12, 2024
@skjnldsv skjnldsv requested review from susnux and a team November 12, 2024 11:47
@skjnldsv skjnldsv self-assigned this Nov 12, 2024
@skjnldsv skjnldsv requested review from nfebe, Pytal, Altahrim and artonge and removed request for a team November 12, 2024 11:47
@skjnldsv
Copy link
Member Author

/backport to stable30

@skjnldsv skjnldsv force-pushed the fix/encode-guest-file-request branch 2 times, most recently from 75029a8 to 79e0e73 Compare November 12, 2024 11:55
@skjnldsv
Copy link
Member Author

/compile rebase

@skjnldsv skjnldsv merged commit 034106d into master Nov 12, 2024
185 checks passed
@skjnldsv skjnldsv deleted the fix/encode-guest-file-request branch November 12, 2024 23:00
@backportbot backportbot bot mentioned this pull request Nov 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux left review comments

@provokateurin provokateurin provokateurin approved these changes

@Pytal Pytal Pytal approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim was automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-backend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: dav feature: files
Projects
Files to vue
Status: Done
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: Upload Error with guest name containing umlaut in File Request
5 participants
@skjnldsv @susnux @Pytal @provokateurin @nextcloud-command