Merge pull request #49226 from nextcloud/fix/encode-guest-file-request

fx(dav): file request guest nickname encoding

apps/dav/lib/Files/Sharing/FilesDropPlugin.php

@@ -64,7 +64,7 @@ public function beforeMethod(RequestInterface $request, ResponseInterface $respo
 		// Extract the attributes for the file request
 		$isFileRequest = false;
 		$attributes = $this->share->getAttributes();
-		$nickName = $request->getHeader('X-NC-Nickname');
+		$nickName = $request->hasHeader('X-NC-Nickname') ? urldecode($request->getHeader('X-NC-Nickname')) : null;
 		if ($attributes !== null) {
 			$isFileRequest = $attributes->getAttribute('fileRequest', 'enabled') === true;
 		}

apps/files_sharing/src/public-file-request.ts

@@ -3,12 +3,13 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
+import { defineAsyncComponent } from 'vue'
+import { getBuilder } from '@nextcloud/browser-storage'
 import { getGuestNickname, setGuestNickname } from '@nextcloud/auth'
-import { spawnDialog } from '@nextcloud/dialogs'
 import { getUploader } from '@nextcloud/upload'
-import { defineAsyncComponent } from 'vue'
+import { spawnDialog } from '@nextcloud/dialogs'
+
 import logger from './services/logger'
-import { getBuilder } from '@nextcloud/browser-storage'
 
 const storage = getBuilder('files_sharing').build()
 
@@ -18,7 +19,7 @@ const storage = getBuilder('files_sharing').build()
  */
 function registerFileRequestHeader(nickname: string) {
 	const uploader = getUploader()
-	uploader.setCustomHeader('X-NC-Nickname', nickname)
+	uploader.setCustomHeader('X-NC-Nickname', encodeURIComponent(nickname))
 	logger.debug('Nickname header registered for uploader', { headers: uploader.customHeaders })
 }