Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #748
Follows #2306
🗒️ Summary
Started looking into how the Bookmarks app was displaying lists and a three-panel-layout and started using some code from there, but realized I should just mimic a basic use case of the current app so that it's not too large of a change and is understandable for others to review
I decided to focus on making the first iteration of the rewrite similar to the current app compact view + mark as read behavior on open (rather than scroll), as that is how I currently use the News app...
VirtualScroll
Component from Bookmarks App#default
template inside of theVirtualScroll
parent component, the VirtualScroll determines which ones to render and when to load more items, or the feed has reached the end of loading:reached-end
property andload-more
attributes should workFeedItem
component for displaying News ItemsStarred
component and route for using VirtualScroll to displaystarredItems
fetched from Vuex storeFeedItem
allItems
starred
starredCount
as separate number that has its own state mutationSET_ITEM
mutation replaces item inallItems
arrayVirtualScroll
)✅ Checklist
- [ ] Changelog entry added for all important changes.(Can we add the label to prevent the check for changelog? )📷 Visual
➡️ Up Next
VirtualScroll
component for: