[Vue Rewrite] Add Unread Item Route and switch to 3 panel-layout #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- started on unread component and using load-more callback from VirtualScroll component - realized we need to change to a 3-panel display because VirtualScroll removes the rendered component even when open if you scroll too much - created FeedItemDisplay component to display a selected feed item details Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
- Reused by Starred and Unread route components Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
devlinjunker
force-pushed
the
unread-items
branch
from
7baa463
to
32867a8
Compare
|
I just tried it on my docker dev setup with over 800 items and it works great. Page load speed is also nice, with the old UI we have these strange artifacts during loading 😄 |
SMillerDev
approved these changes
Aug 25, 2023
devlinjunker
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #748
Follows #2321
🗒️ Summary
Added a new route and component for displaying the unread items, this helped me understand how to use the
VirtualScrollcomponent better.VirtualScrollprevented us from "Expanding" items like the old UI was designed because when you scroll to read the expanded FeedItem it would no longer be in view and would be removed (make it impossible to read a long FeedItem)FeedItemDisplaycomponent for showing the current selected FeedItem (this being separate from theVirtualScrollcomponent means we can scroll and still view the last FeedItem the user clicks on)FeedItemDisplayListcomponent for managing showing the list and the selected Item in the 3rdFeedItemDisplaypanelFeedItemDisplayListcomponent in theStarredandUnreadcomponentsStarted on
Keep UnreadandStar/UnstaractionsAlso started creating Service classes to handle backend requests and prevent duplicating logic
lodashas well, so we can easily debounce the requests to the backend✅ Checklist
- [ ] Changelog entry added for all important changes.(Can we add theskip-changeloglabel to prevent the check for changelog? )📷 Visual
New 3 Panel Layout
Virtual Scroll with 100+ items or just 2 items (starred)
➡️ Up Next
VirtualScrollcomponent for: