fix(NcRichText): Allow markdown parenthesis in URL_PATTERN #6224
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
added
bug
|
I'm not sure which milestones and branches are used in this repo, so feel free to backport however you see fit. |
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/ncrichtext/url-pattern-markdown-parenthesis
branch
from
b3858e2
to
013ae78
Compare
provokateurin
changed the title
Open
4 tasks
nickvergessen
requested changes
Nov 16, 2024
There was a problem hiding this comment.
This needs extensive tests added to not break cases like:
Please check the website (https://nextcloud.com/)
Please check the website https://nextcloud.com/wikipedia_(has-braces)
And the likes. It was a long fight with usability of most users. So we really prefer broken previous over broken UX of normal users posting behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL_PATTERN_AUTOLINK regex already allowed parenthesis from markdown, so the links were clickable, but there was no preview shown due to this regex not allowing them.
☑️ Resolves
🏁 Checklist
nextrequested with a Vue 3 upgrade