-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing differences between NcRichText and Reference API lead to inconsistent link previews #13756
Parsing differences between NcRichText and Reference API lead to inconsistent link previews #13756
Comments
If this is an issue - it is |
Please open in the vue lib (can't move across orgs) |
I don't think so. The regex for resolving references does not handle the closing parenthesis of an embedded link so there is no resolved reference extracted from the test when running the regex on it. To explain it a bit more: |
Ok, after having a closer look I understand why you're saying this is a nextcloud-vue and not server problem. I fixed it both in nextcloud-vue and server: Unfortunately nextcloud-vue uses a hardcoded version of the regex instead of using the one exposed by the capabilities, but at least they are in sync at the moment, so it had to be fixed twice. |
How to use GitHub
Steps to reproduce
https://example.com
[abc](https://example.com)
Expected behaviour
All links should be recognized both in the text and the previews below the message.
Actual behaviour
The NcRichText correctly recognizes the embedded markdown link, but the Reference API doesn't and thus no preview is shown below.
Talk app
Talk app version: main
Browser
Operating system: Arch Linux
Browser name: Firefox
Browser version: 132
I know strictly speaking this is a problem with the Reference API in server, but I filed it here in Talk because I noticed it here and in general I think it is the most impacted place and the devs should be aware of this.
Feel free to move the issue to server, if you feel it is more fitting there.
The text was updated successfully, but these errors were encountered: