Fix for check-manifest pre-commit hook in Python 3.12 #344
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
With Python 3.12,
pre-commit run check-manifest
returns an error of missing dependencies -- see more details in this issue.To fix it,
wheel
needs to be specified as a dependency ofcheck-manifest
in the pre-commit config.This error doesn't show up in CI because:
check-manifest
with Python 3.10 and without the--no-build-isolation
flag.Question
What does this PR do?
Adds
wheel
as a dependency tocheck-manifest
in the pre-commit config.References
The most relevant is this issue. from the cookiecutter repo.
How has this PR been tested?
Tests pass locally and in CI.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: